Code Monkey home page Code Monkey logo

ripple-wallet's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

ripple-wallet's Issues

Feature request: offline signing

Offline signing increases security greatly because secret key doesn't touch an online machine.

  • ripple-wallet creates an unsigned transaction.
  • Transfer the unsigned transaction to an offline computer.
  • Offline ripple-wallet signs the unsigned transaction.
  • Transfer the signed transaction to an online computer.
  • Online ripple-wallet broadcasts the signed transaction.

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): SchemaError: no such schema

Hi,

I've had good success before, but today with 3 different versions of node I keep seeing:

❯ ripple-wallet-cli pay
-----------------------------------------------
Ripple Wallet Make Payment
-----------------------------------------------

? Enter XRP amount to send: 980
? Enter destination address: xxxxxxxxxxxxxxxxxxxx
? Enter destination tag (optional): 102116386
? Enter sender address: xxxxxxxxxxxxxxxxxxxxxxxxxxx
? Enter sender secret: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Current destination balance: 71028.646932 XRP
Current sender balance: 1000.277549 XRP
? Ready to send? Yes

Preparing payment transaction...
(node:11384) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): SchemaError: no such schema </tag>

I'm using the correct inputs, just xxxxx'd them out for this post.

Any ideas or suggestions?

Thanks

Example image data not appropriately obfuscated

It would be possible to figure out the secret from the information provided. The supplied public/private key pair should not be considered safe for holding funds. Also, if the intention in masking the public addresses is to maintain privacy, the provided portions are readily grep-able within any ledgers accountState to reveal the full address. (Information also useful in unmasking the secret.)

I would attempt to convey this information privately, but the repository has already been forked several times. (A safer way to provide examples might be to paste over the real addresses with dummy/unused accounts or random values, prior to taking a screenshot.)

Account not found for the generated wallet

Hi, after installing and generating , I try the balance command and I get :

error: 'actNotFound',
error_code: 19,
error_message: 'Account not found.',
id: 1,
ledger_hash:
'95BB01E1EB2DA7D6554689F135C6CDB4331864C0D37F715003071275A08D5E81',
ledger_index: 59500965,
request:
{ account: 'rQsCyE5r1Z3yJgzS39SpET3hkcsSKM5URa',
command: 'account_info',
id: 1,
ledger_index: 59500965 },
status: 'error',
type: 'response',
validated: true })]

so I dont feel like sending xrp to this wallet :(

also the wallet does not give me any "destination tag" and its required , how do I get that ?

Ripple Wallet Make Payment - BigInt is not defined

On Ubuntu I tried to make payment using this command:
ripple-wallet-cli pay --amount 1 --to rKetLK4uzotxFd27e1MaEgEUJkrYFuK5sy

Ripple Wallet Make Payment

? Enter XRP amount to send: 1
? Enter destination address: rKetLK4uzotxFd27e1MaEgEUJkrYFuK5sy
? Enter destination tag (optional):
? Enter sender secret: xxxxxxxxxxmysecret

Current destination balance: 45.556226 XRP
Current sender balance: 25 XRP
? Ready to send? Yes

Preparing payment transaction...
(node:16866) UnhandledPromiseRejectionWarning: ReferenceError: BigInt is not defined
at Function.Amount.from (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/types/amount.js:69:26)
at /usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/types/st-object.js:128:56
at Array.forEach ()
at Function.STObject.from (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/types/st-object.js:127:16)
at serializeObject (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/binary.js:58:32)
at signingData (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/binary.js:74:12)
at Object.encodeForSigning (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-binary-codec/dist/index.js:37:12)
at computeSignature (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-lib/dist/npm/transaction/sign.js:24:41)
at signWithKeypair (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-lib/dist/npm/transaction/sign.js:47:42)
at RippleAPI.sign (/usr/local/lib/node_modules/ripple-wallet-cli/node_modules/ripple-lib/dist/npm/transaction/sign.js:137:16)
(node:16866) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16866) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Cannot Pay

I'm having an issue running ripple-wallet-cli pay. Do you know what could be the reason?

Current destination balance: 47614.717223 XRP
Current sender balance: 437017.3102 XRP
? Ready to send? Yes

Preparing payment transaction...
/home/tk/.nvm/versions/node/v18.12.0/lib/node_modules/ripple-wallet-cli/node_modules/ripple-lib/dist/npm/transaction/sign.js:163
        return signWithKeypair(this, txJSON, ripple_keypairs_1.default.deriveKeypair(secret), options);
                                                                       ^

TypeError: Cannot read properties of undefined (reading 'deriveKeypair')
    at RippleAPI.sign (/home/tk/.nvm/versions/node/v18.12.0/lib/node_modules/ripple-wallet-cli/node_modules/ripple-lib/dist/npm/transaction/sign.js:163:72)
    at /home/tk/.nvm/versions/node/v18.12.0/lib/node_modules/ripple-wallet-cli/scripts/pay.js:165:45
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.