figui / contactlist Goto Github PK

Optimize unused imports on source files.

You need the Support libraries to cover the entire Android platform.

Definitely much better than before. Some minor details:

You are using Holo Design for old Android devices "android:Theme.Holo.Light.DarkActionBar".

This can be avoid by using the latest versions of support library (v7 and Design), which includes Toolbar and some Material design widgets. This allow you to provide Material design for each version of Android starting from 2.1.

Remember that Interfaces in Java has always public methods. You don't need to declare each method as public explicit.

If you see each 'Parcelable' that you implemented, you can see a linter error which says that the "creator" is missing. This need to be implemented in each case.

Please don't push any IDE-specific files to the repository, you should add them to "gitignore" file.

Please don't merge View logic inside the AsyncTask. You should improve the separation of concerns, don't mess view logic and API logic. For decoupling this, you can use Otto library:

https://github.com/square/otto

Don't need to reinvent the wheel for REST calls, JSON handling and Cache handling.

Please, use the corresponding libraries for this, like Retrofit, GSON, Picasso, etc.

Don't use 'Serializable' for entities, implement 'Parcelable' in those cases.

Use RecyclerView instead of ListView. You need the support library for this.

The MinSDK for this project is API 22. You need to provide support for older Android versions. For example, starting from API 14.

Please, commit the root folder of the project, including the Gradle Wrapper files (gradlew file and folder). Exclude the 'build' and '.idea' folders.