Code Monkey home page Code Monkey logo

rotationsolverreborn's People

Contributors

alymphocyte avatar archidog1998 avatar attickdoor avatar brakustapus avatar chrismellor avatar constmar avatar daemitus avatar deepseaxx avatar efrostblade avatar fatinghenji avatar gamous avatar github-actions[bot] avatar goaaats avatar grammernatzi avatar incognitowater avatar lts-ffxiv avatar molionr avatar niguangowo avatar nostrathomas99 avatar riotnor avatar rlynch-ironnet avatar sciuridae564 avatar silempoleer avatar spaceelysian avatar swoup avatar thesisnegatif avatar thunderebolt avatar tnessy avatar tssailzz8 avatar tykku avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

rotationsolverreborn's Issues

Add IsOpener flag to CustomRotation

Rotations should have an IsOpener flag that the framework sets to true on combat start. The rotation can then operate under different logic conditions until it decides to set this flag back to false on its own.

WHM heals broken completely, RS using only AOE heals.

Yo!
Strange behavior on WHM on last build.
On LTS rotation in auto mode it uses only liturgy for heal, thats all, nothing else, just glare the fuck out of boss.
On Maru its liturgy and medica and still glares.
It does not benediction/regen/cure/solace on some party member, does not mit aoes.
Just constantly dpsing and let the party members die, even player with rs get ignored and died, no self heal at all.

Warrior - Inner release doesn't get used

Hello.

I'm using rotation solver 4.0.0.1.
The last version I was using before worked fine.

On my warrior, inner release doesn't get used while fighting on manual or auto. I tried on mobs, duties and dummies.

There is a way to force use it if you're on manual for example. You start the fight, then click around to unselect the target and poof, inner release get used.

I also tried with my MCH on a variant dungeon (mount), Wildfire didn't get used at all on bosses neither.

Install failed

image

When I install, it stuck at this screen, after stuck, it still showing "Install v4.1.0.1"
Other plugin after stuck will install success. Only Bossmod Reborn & RotationSolverReborn will failed.

Why this happen:
After updated FFXIV at 4/19, I try to update the plugin but pressed delete button, after that I keep this happen.

Tried:
Re-install FFXIV Lanucher
Re-install FFXIV Game
Remove plugin folder in AppData and re-install
Reboot computer
Reboot game

Ninja - Below level 90 issues

  • The Ninki Gauge has not been used to cast 'Bhavacakra' or 'Hellfrog Medium', which are the spells associated with it, since it was unlocked.
  • RSR attempted to use the mudra 'Jin' while doing sub level 45 content, but it was not yet unlocked.

The Samurai's Third Eye often fails to trigger its Additional Effect due to premature usage

This is a long-standing issue with the Samurai's Third Eye. Approximately half the time, the skill fails to trigger its Additional Effect due to premature usage, compounded by the skill's short duration.

In contrast, the Reaper's Arcane Crest almost always triggers successfully.

I suspect this discrepancy arises from the fact that the Samurai's Third Eye lasts for 4 seconds, while the Reaper's Arcane Crest lasts for 5 seconds. However, the timing of such skills' activation is uniform across all jobs, without adjustments based on the specific job.

Given that this issue has existed for a long time (even before the plugin became "reborn"), I personally suspect it may be due to the plugin's default settings rather than the rotations themselves, although I'm not entirely certain.

Limit Break

when trying to use "/rotation doaction limitbreak-5" main settings window opens.

AoE in manual mode

Hey, i did a clean reinstall of the new version, and my warrior is using aoe on manual settings, tho i have this option disabled

ffxiv_dx11_Tw9nK4mdyk

also aoe is correctly greyed out on the control panel

ffxiv_dx11_5PKPxt5esm

I did not find any workaround for now

I'm on rotation solver 4.0.0.1

Timeline doesn't load macro properly

If you add a macro action in the timeline and then reload it changes into something else. This happens when restarting or copying and pasting from clipboard

Bug: Friendly duty NPCs are not targets of heal actions

In healer job quests, players need to keep certain NPCs alive. But as of v4.0.2.3, RSR won't target them for heals, probably because it thinks of them as NPCs rather than party members. This leads to the NPCs dying and the duty failing.

Even with the targeting options "Target allies for friendly actions" and "Target all for friendly actions", the NPCs are not being actively healed. With only the first option enabled, the NPCs are apparently never targeted for healer actions. With both options enabled, the NPCs are targeted for certain protective actions (eg Eukrasian Diagnosis), but apparently not actively healed, or at least not prioritized for survival the way a party tank would be.

To reproduce, do the first SGE job quest (Sage's Focus) on an alt character, and enter the tutorial duty with Lalah Jinjahl. Remove Kardia from her and confront the second mob pack with RSR active. The player SGE will only cast offensive actions and let Lalah die.

Stun actions not being used on melee DPS jobs INSIDE of duties.

Hi.
Im using LTS rotation with MNK and RPR, and notice strange thing, in world stun actions used correctly (if mob tries to aoe and i can interrupt him), but with the same conditions, RS dont stun mobs in dungeons, when they perfrorm AOE attacks. I still manually can stun them.

Feature request or bug: Implementing variant actions

Variant actions (the selectable duty actions available in variant dungeons, e.g. Variant Rampart, Variant Cure) appear to be broken or unimplemented at the moment (RSR v4.0.0.22). Even while in a variant dungeon (e.g. Mount Rokkon) with such actions available to the player as duty actions, these actions do not show up in Rotation Solver's action list, and can't therefore be invoked via conditions. They are also apparently not part of any rotation.

Because variant actions are part of the intended gameplay for variant dungeons, especially solo, I'd greatly appreciate it if someone were to implement them. Most can and should be cast basically on cooldown, so no much work should be required to make them fit into rotations.

Some PvP skills are not activated.

I am writing code for a PvP rotation, but some skills are not activated.

MCHPvP:BishopAutoturretPvP
SMN:SummonBahamutPvP,SummonPhoenixPvP
(public static IBaseAction SummonBahamutPvP { get; } = new BaseAction((ActionID)29673);)
(public static IBaseAction SummonPhoenixPvP { get; } = new BaseAction((ActionID)29678);)

Feature request and a bugfix: implement anti-kb abilities

Yo!
I will know that RS learns on new abilities that been used by mobs in dungeons, and must use mits for it.
RN its not working, because my list is the same (list>actions) as i installed RS. Or RS do not displaying that it learns something.
My idea is fix this list thing if its broken, and let RS remembor what AOE/KB/TB hit it and next time, when same ability being cast from mob, RS will use antikb/mits/etc to prevent getting hit.

(also, Nostra, sleep at least 8 hours pls)

AoE abilities no longer trigger in Manual mode

Before last night's maintenance, I was using manual mode with the 'Use AoE actions in manual mode' setting enabled, and it worked perfectly. However, after logging in today, it appears to no longer function. Everything operates as expected in Auto mode, but I prefer using manual mode with the AoE option.

Sage - Eukrasian Diagnosis Spam

I don't think this was an issue before I switched over to this repo.
Sage constantly spams Eukrasian Diagnosis (on MT) when not in combat, it's not fishing for a crit but is just needlessly draining mana. Is there a way to disable this? Or return it to 'cast it once' sort of thing.

Samurai - Yukikaze "hanging"

issue with LTS samurai rotation showing no "next skill" in the next skill window at Yukikaze in both single target and AoE scenarios. Periodic issue with it, not sure what exactly makes it reproducible. Possibly a hang where it wants to use Iaijutsu and using yukikaze would cause it to gain a sticker it already has, wasting gcd?

Pebkac: Feature Request: Possible Off Tank Situation And Maybe Allowing /rotation DoAction Command To Trigger Disabled Action

Woop that was a long title.

  • I have been trying out tank in duties and find out every time I load into a duty, the rotation automatically turns on tank stance. Tried turning it off, it instantly turn it back on. Issue being, it is impossible to play as Off Tank with RSR. ( Possible rotation optimization issue instead of RSR issue )
  • Because of the above issue, i disabled the action in Action list and hence I can't trigger the action using /rotation DispelStancePositional . Need to use vanilla action button to trigger the action.
  • Possibly a better automation setting for Provoke, so it does not spam Provoke on cases like Off Tank / Alliance Raid / Hunts where multiple tanks exist attacking the same mob.

Thank you :D

True North Does not use the second stack

True North is used properly for the first stack, no longer double taps or overlaps buff. However now it does not use the second stand no matter what. It appears to be waiting for the CD to come up from the first use. Doesnt know there is a second stack to use if do not have the buff already?

Issue with Automatic Placement of "Ley Lines" in Black Mage Rotation (Reposted)

(Please note this issue is still ongoing and was posted in the wrong portion of the repository, I'm only reposting it so that it is in the proper location for reporting bugs.)

There seems to be an issue where the "Ley Lines" ability for the Black Mage rotation is not automatically placing on the ground when automatic rotation is enabled. This problem is similar to a previously fixed issue with other abilities that were placed on the ground, which was caused by a check that prevented abilities with an "invalid target" from firing.

Steps to Reproduce (Current is on the testing version, v1.4.0.3):

Engage in combat using the Black Mage rotation with auto rotation enabled.
Reach the combat state where "Ley Lines" should automatically activate.
Observe that the ability does not place automatically as expected.

Expected Behavior:

"Ley Lines" should automatically place on the ground under the conditions specified in the rotation script when the combat criteria are met.

Actual Behavior:

"Ley Lines" does not auto-place, requiring manual intervention to activate.

Possible Causes (?)

There may be an underlying check within the API or framework that incorrectly categorizes the ground as an invalid target for "Ley Lines".

Conditional logic surrounding the activation of "Ley Lines" might not be evaluating as expected.

Possible solutions (?)

Reviewing and confirming the API or framework documentation to ensure correct usage and behavior of ground-targeted abilities.
Implementing detailed logging around the "Ley Lines" activation code to capture its behavior during combat scenarios.
Testing "Ley Lines" under simplified conditions to isolate whether the issue lies with the ability's placement logic or the surrounding combat conditions.

Additional Information:

Game Version: 6.58
API Level: 1
Code Module: BLM_Default rotation in the DefaultRotations/Magical namespace for LTS rotations, but also tested on the BETA rotations.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.