felipec / git-related Goto Github PK

I recently got an error out of git blame (I think)

fatal: no such path L in <arbitrary-commit-sha-out-of-the-defined-range>~

after executing

git related --roles <commit-sha-1>..<commit-sha-2>

What makes me think it is an issue with git blame is this line. But I do literally do have zero experience with ruby so I'm stuck in tracking the issue down to the real cause.

Some authors with umlaut letters in their names can get author details in git blame containing invalid UTF-8, specifically if they're on strange systems like windows.
By doing line.encode! :invalid=>:replace before trying to match strings in get_blame, I've personally managed to get around that issue, but that might not be a useful fix for everyone. Anyhow, just a heads up. :)

Hi,

I just cloned and installed git-related and upon executing it, I always get

git related
/home/me/bin/git-related:258: syntax error, unexpected ']'
      $base_rev = revs[1][1..]
                             ^
/home/me/bin/git-related:326: syntax error, unexpected end-of-input, expecting keyword_end

My Ruby version is

ruby --version
ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-linux-gnu]

Any idea as to what the problem is?

If two commits are not diverged, i.e. on the same line, git related does not show any results, but I'm not sure if this behavior is a by-design.

Most OSes ship with older versions of ruby - it would be good to make this work out of the box for people without ruby 2.

$ git related master
/Users/danielheath/.bin/git-related:71: syntax error, unexpected tLABEL
def on(short = nil, long = nil, help: nil, &block)
^
/Users/danielheath/.bin/git-related:71: Can't assign to nil
def on(short = nil, long = nil, help: nil, &block)
^