fedora-cloud / cloudtoserver Goto Github PK

Line 37 should read:
print "There was an issue while converting to Fedora Server. Please report the error"

or:
print "There were issues while converting to Fedora Server. Please report the error"

Attempting to update a cloud instance provides little insight into what's happening when it errors out.

For instance:

• Run as non-root:
  • Expected result: "You need to run this as root."
  • Actual result: "There was issues while converting to Fedora Server. Please report the error Use https://paste.fedoraproject.org for pasting the output from this command."

This doesn't help us much with debugging what might have gone wrong and also doesn't give the user anything to actually paste.

It is not clear cloud-init would remain in Fedora cloud and it is possible it would be replaced by min-cloud-agent. Even otherwise, it is probably better to abstract away the internal details in the syntax

" parser.add_argument("-s", "--stopci", help="Stop cloud-init service","

replace --stopci with --stopcloud-service? Also, why is it necessary for this to be an option? Why not just do it automatically?

yum is getting replaced by dnf in Fedora 22. If yum is not found, you need to fallback to using dnf, preferably via the dnf api. I will be happy to submit a pull request. let me know