federicogianni / ing-sw-2019-collovigh-contini-dei_cas Goto Github PK

As from requirements doc:

Requisiti Soddisfatti Voto Massimo
Regole Semplificate + CLI + (Socket o RMI) 18
Regole Complete + CLI + (Socket o RMI) 21
Regole Complete + CLI + (Socket o RMI) + 1 FA 22
Regole Complete + GUI + (Socket o RMI) + 1 FA 24
Regole Complete + GUI + Socket + RMI + 1 FA 27
Regole Complete + CLI + GUI + Socket + RMI + 1 FA 30
Regole Complete + CLI + GUI + Socket + RMI + 2 FA 30L

Your maximum grade would be 21, even if you implemented much more. Are you really sure you don't want to deliver any advanced functionality? With just one your maximum grade will become 30...

Hi, this issue is to inform you that two of your tests are failing. Moreover, your tests are way too verbose, please delete all the println.

[ERROR] Tests run: 20, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.265 s <<< FAILURE! - in it.polimi.ingsw.model.NormalWeaponTest
[ERROR] heatSeekerTest Time elapsed: 0.015 s <<< FAILURE!
java.lang.AssertionError
at it.polimi.ingsw.model.NormalWeaponTest.heatSeekerTest(NormalWeaponTest.java:849)

[ERROR] grenadeLauncherTest Time elapsed: 0.007 s <<< FAILURE!
java.lang.AssertionError
at it.polimi.ingsw.model.NormalWeaponTest.grenadeLauncherTest(NormalWeaponTest.java:1031)

You can allow an empty name.
I tried once, and the second client get:

@test
void getPowerUp() {

}

@Test
void getAmmoCube1() {
}

@Test
void getAmmoCube2() {
}

@Test
void getAmmoCube3() {
}

}

pls fix asap

I got:
java.net.ConnectException: Connection refused (Connection refused)
at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)
at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:242)
at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:224)
at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:403)
at java.base/java.net.Socket.connect(Socket.java:591)
at java.base/java.net.Socket.connect(Socket.java:540)
at java.base/java.net.Socket.(Socket.java:436)
at java.base/java.net.Socket.(Socket.java:213)
at it.polimi.ingsw.network.client.socket.SocketClient.run(SocketClient.java:103)
at java.base/java.lang.Thread.run(Thread.java:835)
Jul 07, 2019 12:25:37 PM it.polimi.ingsw.network.client.socket.SocketClient run
WARNING: Could not find the server

pls manage gracefully "no server".