featurehub-io / featurehub-helm Goto Github PK

Helm chart should allow the default values for the deployments to be configurable.

I would like to request that an initContainers section be added to the helm chart -> templates -> management-repository -> deployment.yaml file.

The use case is having a sidecar that can inject the backend credentials for the Postgres connection for the management-repository service to consume prior to the FeatureHub service starting and without needing to create a Kubernetes secret, or supply the credentials directly as an environment variable to be put in the configMap.

helm template featurehub -f values.yaml .
getting the following error after adding annotations for the global ingress:

coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:200: warning: cannot overwrite table with non table for annotations (map[alb.ingress.kubernetes.io/backend-protocol:HTTP alb.ingress.kubernetes.io/certificate-arn:redacted alb.ingress.kubernetes.io/group.name:testing-featurehub alb.ingress.kubernetes.io/listen-ports:[{"HTTPS":443}] alb.ingress.kubernetes.io/load-balancer-attributes:routing.http.drop_invalid_header_fields.enabled=true alb.ingress.kubernetes.io/scheme:internal alb.ingress.kubernetes.io/ssl-policy:ELBSecurityPolicy-FS-1-2-Res-2020-10 alb.ingress.kubernetes.io/tags:environment=testing,product=featurehub,sub-product=ALB-internal alb.ingress.kubernetes.io/target-type:ip kubernetes.io/ingress.class:alb])
coalesce.go:200: warning: cannot overwrite table with non table for annotations (map[alb.ingress.kubernetes.io/backend-protocol:HTTP alb.ingress.kubernetes.io/certificate-arn:redacted alb.ingress.kubernetes.io/group.name:testing-featurehub alb.ingress.kubernetes.io/listen-ports:[{"HTTPS":443}] alb.ingress.kubernetes.io/load-balancer-attributes:routing.http.drop_invalid_header_fields.enabled=true alb.ingress.kubernetes.io/scheme:internal alb.ingress.kubernetes.io/ssl-policy:ELBSecurityPolicy-FS-1-2-Res-2020-10 alb.ingress.kubernetes.io/tags:environment=testing,product=featurehub,sub-product=ALB-internal alb.ingress.kubernetes.io/target-type:ip kubernetes.io/ingress.class:alb])
coalesce.go:200: warning: cannot overwrite table with non table for annotations (map[alb.ingress.kubernetes.io/backend-protocol:HTTP alb.ingress.kubernetes.io/certificate-arn:redacted alb.ingress.kubernetes.io/group.name:testing-featurehub alb.ingress.kubernetes.io/listen-ports:[{"HTTPS":443}] alb.ingress.kubernetes.io/load-balancer-attributes:routing.http.drop_invalid_header_fields.enabled=true alb.ingress.kubernetes.io/scheme:internal alb.ingress.kubernetes.io/ssl-policy:ELBSecurityPolicy-FS-1-2-Res-2020-10 alb.ingress.kubernetes.io/tags:environment=testing,product=featurehub,sub-product=ALB-internal alb.ingress.kubernetes.io/target-type:ip kubernetes.io/ingress.class:alb])
coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []
coalesce.go:203: warning: destination for annotations is a table. Ignoring non-table value []

cloned this repo and used this chart as the source with the same values.yaml and everything seems to be fine.
looks like both of them are 3.0.6 and the global-ingress.yaml is the same (unless im missing something) so, weird.
might want to look into it.

Chart.yaml

apiVersion: v2
description: FeatureHub on EKS
name: featurehub
version: 1.0.0

dependencies:
- name: featurehub
  version: ~3.0.0
  repository: https://featurehub-io.github.io/featurehub-helm/

values.yaml:

featurehub:
  global:
    ingress:
      annotations:
        alb.ingress.kubernetes.io/certificate-arn: redacted
        alb.ingress.kubernetes.io/group.name: testing-featurehub
        alb.ingress.kubernetes.io/tags: environment=testing,product=featurehub,sub-product=ALB-internal
        kubernetes.io/ingress.class: alb
        alb.ingress.kubernetes.io/scheme: internal
        alb.ingress.kubernetes.io/target-type: ip
        alb.ingress.kubernetes.io/backend-protocol: HTTP
        alb.ingress.kubernetes.io/load-balancer-attributes: routing.http.drop_invalid_header_fields.enabled=true
        alb.ingress.kubernetes.io/ssl-policy: "ELBSecurityPolicy-FS-1-2-Res-2020-10"
        alb.ingress.kubernetes.io/listen-ports: '[{"HTTPS":443}]'

after set custom url for reverse proxy, on environment variable featurehub.url-path the health check fail, causing crash loop.

I change the edge image to "edge-rest" and disable both dacha1 and dacha2, but management-repository tries to connect to NATS servers. I disabled nats and dacha. I believe the problem is that the mr is checking for "nats.urls" and there is no way to set it back to null from its default value in the default values.yaml

Helm install failed: parse error at (featurehub/templates/management-repository/deployment.yaml:71): function "Values" not defined

The template has "Values" instead of ".Values"

Hi team,
we are integrating feature-hub into our ecosystem for all our product line, we wanted to integrate the google cloud hosted pub-sub into the feature-hub(hem chart) which we have deployed into our GKE cluster, currently the official documentation shows the implementation of a docker-compose based solution which has a pub-sub emulator as a container and passing the details of the pub-sub in the environment for edge and MR.

How do i integrate/pass the details for pub-sub that is hosted in GCP, Please help me how do i integrate it to connect to google cloud pub-sub

3.0.6 which is the latest version in the helm chart is pointing to appVersion:1.5.8 which is not the latest release.
I'm suggesting adding a Github Action or some other automated task that bumps the appVersion of this repo when creating a new release in the main featurehub repo.

Probably better do it in the featurehub repo and not here, but opening here since the issue is Helm related.

Hi,
Firstly, I would like to thank you for the good work and for this wonderful system.

I have a little small issue when trying to deploy featurehub with customized root podAnnotation (with special characters example bellow), I get always errors like helm is not able to parse the chart values as string. and this is because of the special characters in my podAnnotations.

**podAnnotations**: Key1: value1 Key2: '["value2"]' Key3: value3

I found a basic solution using quote function to allow special characters. code example bellow.
here a quick fix for that :
{{- range $key, $value := .Values.podAnnotations }} {{ $key }}: {{ $value | quote }} {{- end }}

Another question I have, why are you using the .Values.dacha.podAnnotations for dacha deployment while for mr server and edge you use .Values.podAnnotations is there any reason behind this choice ?

thanks a lot
Youness

In order to deploy FeatureHub in High Availability mode securely, it is necessary to specify the NATS routes using nats.urls in the in environmentVars in the format nats://user:password@url.

This allows NATS clusters to communicate with one another using authentication (with the authorization config set on each NATS cluster). However there is no way to set these env vars using a secret, meaning they are exposed in plain text.

The ability to set global.envFromSecret would allow the setting of nat.urls which include sensitive information.