Put additional info to after hooks called by rethinkdb changefeed about feathers-rethinkdb HOT 7 CLOSED

I was thinking about the exact same thing. We could set params.changefeed to the changefeed values and do both things at once.

from feathers-rethinkdb.

I was also debating that for the 1.0 release we may want to make watching changefeeds an explicit option due to some of the caveats I outlined in #76

from feathers-rethinkdb.

Agreed, watch should be false by default. As for me all events for any services in feathers should be switchable but issue not about it...
So, can I create a PR for changefeed? My personal interest in old_value for update event, new value available in hook.result. So what exactly changefeed field should contains?

from feathers-rethinkdb.

@daffl pss, so what about PR?

from feathers-rethinkdb.

@daffl so what do you say? My proposal is to have:
changefeed = {
old_val?:Object;
new_val?:Object;
}

and new_val will be duplicated in hook.result for hook behavior consistency.

from feathers-rethinkdb.

@daffl This would be very useful to me as I'm trying to create an after hook that only sends an email if a user role gets changed directly from the database. Not sure how to accomplish this without the old_val also.

from feathers-rethinkdb.

Closing, see #119

from feathers-rethinkdb.