Missing TypeScript Support/Typings Support about feathers-rethinkdb HOT 6 CLOSED

Thank you for the suggestion @davidfarinha. It would be great if someone is interested in taking this on.

Due to the uncertain state of RethinkDB and the low usage numbers of this module (as compared to other database adapters) I am not actively looking into adding any new features myself though.

from feathers-rethinkdb.

OK understandable. Awesome framework by the way! I'd be happy to help and create the TypeScript typings for this module so I can take this on.

Cheers,
David Evans

from feathers-rethinkdb.

I've made the typescript typings for this module and added a pull request on DefinitelyTyped. When merged, these TypeScript typings will available on npm as "@types/feathers-rethinkdb" and this issue can be closed.

Link to Pull request (DefinitelyTyped #27879)

Link to new feathers-rethinkdb typings/declaration file.

If you ever need any additional TypeScript help with feathers in the future, let me know I'd be happy to help out!

Cheers

from feathers-rethinkdb.

Sweet, thank you! We can add it as a dependency as well once it is published (so that types are pulled in automatically).

from feathers-rethinkdb.

Just an update on this.

I've created and tested the type definitions for this package, they extend the (very thorough) "types/rethinkdbdash" and "types/rethinkdb" typings. These appear to be the best typings available to extend the core rethinkdb/rethinkdbdash (as opposed to the rethinkdb typings on DefinitelyTyped which are not yet fully complete).

DefinitelyTyped isn't the appropriate place for the new typings, since they depend on these other external types (and DefinitelyTyped is meant for packages that provide their own types or depend on other internal types, not for depending on other github repositories) so instead they could be bundled into this package or hosted separately on github and npm.

from feathers-rethinkdb.

The types are up on my github repo for now which is enough to close this issue.
Cheers

from feathers-rethinkdb.