Return `error.response.json()` doesn't resolve using fetch about feathers-rest HOT 5 CLOSED

Does

app.service('/messages').create({
  text: 'Hello'
}).then(result => {
...
}).catch(error => {
return error.response.json() // Never resolves
}).catch(console.error.bind(console));

log anything? I'm wondering if error.response.json() throws (I'm not sure what it's supposed to do) or something before.

from feathers-rest.

This is the closest I can get at replicating.
https://github.com/mcchrish/feathers-fetch-error
Sorry, it requires a couple of steps:

npm start

Then test by mocha:

mocha test/client.test.js

It pauses at return error.response.json() then mocha will timeout.

from feathers-rest.

If you return something in a Promise catch, that promise is no longer rejected. In your example (thank you for uploading) something like

app.service('/messages').create({})
      .catch(error => {
        console.log('!!!!', error.message);
        throw error;
      })

Works as expected. If you make sure that you have the latest version of feathers-rest installed (the one that includes #53) the error will also be converted properly to a Feathers error and there shouldn't be a reason for calling error.response.json().

from feathers-rest.

Oh, so that's what changed.
Using 1.4.* currently, while reverting 1.3.0 makes my code works.
That's why there is no need for error.response.json() anymore, which is pretty neat.

Thanks 👍

from feathers-rest.

Ah sorry, I didn't think it would be a breaking change since the REST error handling (especially for fetch and jQuery) was kind of broken before but obviously it needed to be worked around then. Glad we figured it out and hopefully this fix will make things easier.

from feathers-rest.