Code Monkey home page Code Monkey logo

Comments (4)

daffl avatar daffl commented on July 22, 2024

I think, technically, PUT shouldn't do automatic upserts. You can register your own middleware to set the status after a service though:

app.use('/myservice', service, function(req, res, next) {
  const data = res.data; // service call result

  res.status(getStatusFromData(data))  ;

  next();
});

from feathers-rest.

immanuel192 avatar immanuel192 commented on July 22, 2024

HI @daffl

Thanks for your response. If we use middleware to set the status after service invoked, then the our code in service could be come more complex. Why dont we let the service to handle it custom status whenever they need?

Trung

from feathers-rest.

daffl avatar daffl commented on July 22, 2024

What would be more complex?

As pointed out in this FAQ the main reason to not let the service itself do it is that they shouldn't know about how they are being accessed. A service can also be used via websockets or locally (or other non-HTTP transport mechanisms in the future) in which case setting an HTTP status code doesn't make any sense.

If you really really need it you can always add the request and response object to params in a middleware but we recommend not to do that.

from feathers-rest.

immanuel192 avatar immanuel192 commented on July 22, 2024

Thanks

from feathers-rest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.