Set Accept header as default about feathers-rest HOT 8 CLOSED

I'm pretty sure the feathers-rest adapters (request, jquery, etc.) already do this. That note is more for when people are using POSTman or curl. If not then would you be up for submitting a PR?

from feathers-rest.

It seems to be a pretty common mistake to forget to set the Accept header when trying out the API so it might be confusing to get HTML back. I don't think it would be a big change to default to application/json when it isn't set.

from feathers-rest.

Ya I can fix it in the error handler. I already did it in the feathers-authentication middleware.

from feathers-rest.

The feathers-rest Adapter sets theContent-Type to application/json, but not the Accept header.

from feathers-rest.

@HaNdTriX what I was getting at is that I think some of the adapters already do set it jQuery and request I think do this themselves but you are right we are probably better off setting them explicitly ourselves.

I'm also updating the error-handler to return errors as JSON by default.

from feathers-rest.

FYI I've pushed [email protected] that now responds with JSON by default and will work if you provide an Accept or Content-Type header, or both.

from feathers-rest.

Thanks! Works like a charm!
FYI: I was using superagent which doesn't set the Accept header.

from feathers-rest.

I've created an issue for superagent. #29

from feathers-rest.