fchikwekwe / cs-2-2 Goto Github PK

Hello, I was just checking your tutorial progress and wanted to note something regarding tests. If you decide to take this class for credit, please note this issue otherwise, feel free to close it.

• You must write at least one unit test in order for your work to be considered for a grade. Furthermore, if you write only one test, you must score higher in another category on the rubric.

Challenge 1 Feedback: 10/20

Code based on Challenge 1 Rubric
Overall: Code is generally good, need to improve file reading and add more error handling.

• Solution 4

  • sample 3 file has an edge to a vertex not in the vertex list - your code should either error on this or add the vertex in - yours does neither.

• Documentation 3

  • Looks good - consider adding parameters and runtime to docstrings.

• Code Organization 2

  • Need to separate file reading from graph creation - these should not be coupled.

• Testing 1

  • A few tests but not error handling