fazibear / airbrakex Goto Github PK
View Code? Open in Web Editor NEWElixir client for the Airbrake service.
License: MIT License
Elixir client for the Airbrake service.
License: MIT License
Right now, I need to explicitly wrap all processes that do not run through the plug to get error handling.
I'd like to just use the backend that you wrote to catch everything, but then I'm getting double reporting with the plug. It would be nice to have another ignore key like :ignore_backend
that could have a different function than ignore (e.g. ignore anything from MyApp.Endpoint
module...).
Using the plug with the new version raises and error:
[error] #PID<0.542.0> running RegistrarWeb.Endpoint (cowboy_protocol) terminated
Server: localhost:4000 (http)
Request: GET /sadfasdf
** (exit) an exception was raised:
** (FunctionClauseError) no function clause matching in Map.from_struct/1
I believe is is associated to this change: https://github.com/fazibear/airbrakex/blob/master/lib/airbrakex/notifier.ex#L39
The plug returns errors as a map already and Map.from_struct/1
is expecting a struct.
I'll try and put a fix in if I can as I'm already working on putting in tests for the plug (so that I can add URLs to the context with the plug)
Our Airbrake notification errors have been working correctly until recently when we started getting SSL certification errors:
iex(1)> Airbrakex.notify RuntimeError.exception("hi")
[error] SSL: :certify: ssl_handshake.erl:1605:Fatal error: bad certificate
{:error, %HTTPoison.Error{id: nil, reason: {:tls_alert, 'bad certificate'}}}
config :airbrakex,
environment: to_string(Mix.env()),
project_key: Env.get("AIRBRAKE_API_KEY"),
project_id: Env.get("AIRBRAKE_PROJECT_ID"),
endpoint: "https://airbrake.io"
Does it look like we have the configuration wrong?
iex(2)> Airbrakex.notify(%UndefinedFunctionError{reason: "test"})
{:ok,
%HTTPoison.Response{body: "",
headers: [{"Location",
"https://airbrake.io/api/v3/projects/142622/notices?key=9ed9a66fa0482ea7155c89b1c5389
eda"},
{"Content-Length", "0"}, {"Connection", "keep-alive"}], status_code: 301}}
Seems like we should be using https://airbrake.io
now.
Also, the default of this lib is to use http, not https. This seems like a security risk
Does this package support lager(erlang's logger framework)?
Since the readme does not specify, I would have expected the :ignore
key to work for all requests (going through the plug or just calling .notify
directly as the readme suggests).
The check to ignore is only happening in the plug:
airbrakex/lib/airbrakex/plug.ex
Line 45 in b7b5a94
GenEvent handler Airbrakex.LoggerBackend installed in Logger terminating {:noreply, %{level: :error, metadata: []}} Last message: {:io_reply, #Reference<0.3354249149.804257793.86467>, :ok}
GenServer #PID<0.180.0> terminating {:noreply, %{level: :error, metadata: []}} Last message: {:gen_event_EXIT, Airbrakex.LoggerBackend, {:noreply, %{level: :error, metadata: []}}}
Exceptions seem to still get reported, though I'm unsure if any are missed.
Not looks like the library is working, when i run the example of exception manually i dont receive success status but 301 redirect:
{:ok,
%HTTPoison.Response{body: "",
headers: [{"Location",
"https://airbrake.io/api/v3/projects/126886/notices?key=ed8b5d05367bea21a3576a5ec31abb6b"},
{"Content-Length", "0"}, {"Connection", "keep-alive"}], status_code: 301}}
And the exception not shows in Airbrake dashboard.
When the Airbrakex logger backend is used with the Console logger backend an error makes terminate the GenEvent process.
Cf. example https://github.com/gsempe/airbrakex-logger-backend
Current version in master is 0.1.7 and in hex.pm it is 0.1.6 , what's the reason of this?
When the request fails this lib silently fails. I think we should have some form of check here.
Hello,
We use Airbrakex.Plug for tracking our Elixir errors and we would like to include in the context of the notice that this is an Elixir error. When the Plug calls Notify.notify/2, it does not pass a context, so it seems that this is the function head that gets hit:
https://github.com/fazibear/airbrakex/blob/master/lib/airbrakex/notifier.ex#L38-L40
We would like in those cases for the context language to be set to "Elixir". Would you be open to a PR that makes that change? Or would you prefer that be configurable in some way?
Since Mix
is not(and should not) included to a release, executing this command inside a release:
Application.get_env(:airbrakex, :environment, Mix.env)
causes an exception like this:
** (exit) an exception was raised:
** (UndefinedFunctionError) undefined function Mix.env/0 (module Mix is not available)
Mix.env()
You can either make environment
param mandatory and remove default
value(which is Mix.env
) from get_env
function call OR you can merge this PR #9. To be honest I don't know which option is better, probably the first one.
It would be nice to be able to configure the endpoint one is hitting, as some organizations have their own Errbit instances running privately. You'd currently have to maintain a private fork of this repo to make that work. I'd be happy to submit a PR.
currently, to ignore all errors in a specific environment (such as :test
or :dev
), you set :ignore
config to a simple function that returns true:
config :airbrakex,
ignore: fn(_error) ->
true
end
it'd be more concise / convenient to allow users to set a boolean value here instead:
config :airbrakex, ignore: true
i have a branch open with the change. let me know if this is something you want to support, and i'll be happy to open a PR.
Would be really useful,
e.g.
Ecto.NoResultsError
is totally legit exception that should not be tracked anyhow
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.