Code Monkey home page Code Monkey logo

Comments (9)

fatih avatar fatih commented on May 24, 2024

Hi @pathaugen,

Does it also fail if you just use the https://github.com/mattn/go-colorable package? If yes you should open an issue there, if not let me know please. The color package is fully ANSI compatible, so it should just works if go-colorable works as well (which was btw)

from color.

pathaugen avatar pathaugen commented on May 24, 2024

If another package is preventing yours from working I'll point this out:

We moved to:
https://github.com/shiena/ansicolor

Fully ANSI compatible as you state color is supposed to be.

Now everything works with ansicolor in Windows 10. It's a simple package for Windows coloring that doesn't have issues.

color-fail-2

Using that package instead of go-colorable within your own, or using the solution they implement in their code which works for Windows 10 full ANSI would solve the issue, but either way the ANSI compatibility isn't working for Windows 10 as you currently have it.

from color.

fatih avatar fatih commented on May 24, 2024

We were using it already, but then @mattn switched it to go-colorable to support 256 colors: #25

@mattn do you know what the problem here is ? I don't have a windows machine and can't validate the issue.

from color.

pathaugen avatar pathaugen commented on May 24, 2024

Switching from it may be when it broke for me.

Should note, you have to test in Windows 10 separate from pre-10 due to the changes to the windows console subsystem.

Here is an interesting read, to get some background beyond "Windows 10 is different"
http://www.nivot.org/blog/post/2016/02/04/Windows-10-TH2-%28v1511%29-Console-Host-Enhancements

Either way, ansicolor works. Love color for non-Windows would like to see Windows polished up so hope this helps.

from color.

mattn avatar mattn commented on May 24, 2024

I'll look into it later.

On 6/25/16, Patrick William Haugen [email protected] wrote:

Switching from it may be when it broke for me.

Should note, you have to test in Windows 10 separate from pre-10 due to the
changes to the windows console subsystem.

Here is an interesting read, to get some background beyond "Windows 10 is
different"
http://www.nivot.org/blog/post/2016/02/04/Windows-10-TH2-%28v1511%29-Console-Host-Enhancements

Either way, ansicolor works. Love color for non-Windows would like to see
Windows polished up so hope this helps.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#32 (comment)

  • Yasuhiro Matsumoto

from color.

mattn avatar mattn commented on May 24, 2024

doesn't reproduce. I'm on Windows 10 64bit

from color.

fatih avatar fatih commented on May 24, 2024

Thanks @mattn for the validation. @pathaugen as you see above, it's working without any problem. Maybe you did something wrong, but as you see it just works.

from color.

dshafik avatar dshafik commented on May 24, 2024

I have now been able to reproduce this. It depends on the terminal you're using:

  • Cmder/ConEmu: Works fine, in Bash for Windows, Cmd.exe, and powershell.exe
  • powershell.exe: Works fine, though some colors are not visible (like Yellow)
  • cmd.exe: shows escape codes as per @pathaugen

from color.

joegrasse avatar joegrasse commented on May 24, 2024

@mattn @fatih @dshafik

powershell.exe: Works fine, though some colors are not visible (like Yellow)

On windows 10 powershell, I can get Yellow to show if I Bold it.

from color.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.