Code Monkey home page Code Monkey logo

Comments (10)

revolter avatar revolter commented on July 27, 2024 1

But others are not listed there although set:
fastlane/fastlane:fastlane/lib/fastlane/actions/gym.rb@master#L82
(Probably comes from somewhere else?)

XCODEBUILD_ARCHIVE comes from https://github.com/fastlane/fastlane/blob/f08038b71e11d1338ca2222f3eaf9deff7c244c6/fastlane/lib/fastlane/actions/xcodebuild.rb#L5.

IPA_OUTPUT_PATH is also written to an ENV variable:
fastlane/fastlane:fastlane/lib/fastlane/actions/gym.rb@master#L77-L78

You don't need this information, as IPA_OUTPUT_PATH is defined in the SharedValues module, which can be extracted in the documentation.

from docs.

revolter avatar revolter commented on July 27, 2024

The env variables are defined in the options.rb files (e.g. gym's options). And I guess you have to edit ActionDetails.md.erb to include config_item.env_name.

from docs.

janpio avatar janpio commented on July 27, 2024

That can only be part of it. gym creates SharedValues::IPA_OUTPUT_PATH for example, gradle creates SharedValues::GRADLE_APK_OUTPUT_PATH.

from docs.

revolter avatar revolter commented on July 27, 2024

I don't know about SharedValues, I was only referring to env variables.

from docs.

janpio avatar janpio commented on July 27, 2024

A bit of investigation:

Some SharedValues seem to be "defined" here:
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/gym.rb#L3-L6
But others are not listed there although set:
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/gym.rb#L82
(Probably comes from somewhere else?)

IPA_OUTPUT_PATH is also written to an ENV variable:
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/gym.rb#L77-L78
Same for DSYM_OUTPUT_PATH:
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/gym.rb#L83

from docs.

janpio avatar janpio commented on July 27, 2024

You don't need this information, as IPA_OUTPUT_PATH is defined in the SharedValues module, which can be extracted in the documentation.

If this is consistent across all actions and plugins... I assumed it may not be ;)

But I agree, exposing "SharedValues" would probably be a great first step.
Then maybe define some rules about how it should be used in actions and plugins so it is consistent.

from docs.

mollyIV avatar mollyIV commented on July 27, 2024

👋 We created a ticket about documenting SharedValues: fastlane/fastlane#14730

Maybe we can tackle ENV (environment variables for input parameters) in a separate ticket once we finish with the SharedValues? 🤔

from docs.

janpio avatar janpio commented on July 27, 2024

Sounds like a plan. As ENV variables are not tracked anywhere, this might be a bit more effort though - maybe it makes sense to add something similar to SharedValues that also lists the ENV variables and also explains what they are used for.

from docs.

janpio avatar janpio commented on July 27, 2024

@mollyIV, do you think we can/should close this issue as solved with what you implemented?

from docs.

mollyIV avatar mollyIV commented on July 27, 2024

Document SharedValues ...

The part about documenting SharedValues is already implemented ✔️ If you go to the fastlane documentation, you can check what (if any) SharedValues are produced by an action, for instance build_ios_app action.

... and ENV variables created by actions

We created separate tickets to tackle it:

So overall I think we can close this ticket 👍

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.