Comments (3)
I disagree. extract.js
is included to prove the library works, and it works as such.
These 'value-add' features are 'feature-creep' and should be for another project.
I feel this is a back-end library and should be for the protocol and documentation only.
from heroprotocoljs.
In order for people working on other projects to leverage the library fully, it needs to make deciphering the replays content as easy as possible. The documentation is part of that, but reading extracted files manually to get a feel of them is another.
If someone just wants to dump data to be exploited elsewhere, not using the --pretty
option outputs a one-line file with a direct JSON representation of the data.
If someone wants to have a manual look at the inside of a file, they can add the --pretty
option to add new lines and indent. The original library also sorted the properties alphabetically, I suppose for readability reasons. As the --pretty
option is not intended for optimized code but for debugging and exploration in the first place, it has all it's place here.
from heroprotocoljs.
Done 8204114.
from heroprotocoljs.
Related Issues (20)
- Replays from newer patch uses older protocol HOT 1
- Code commenting HOT 1
- Prettying up and modernizing the code HOT 4
- Tests HOT 1
- Write initial replay.game.events reference HOT 1
- Grunt HOT 1
- extract.js - add options to only extract certain files HOT 2
- extract.js - add option to skip existing files HOT 2
- extract.js - keep directory structure when extracting directories recursively
- Write initial replay.attributes.events reference
- Query tool HOT 6
- Spread operator not supported in Node v4 HOT 2
- TypeError: decoder.CorruptedError is not a function HOT 2
- One less abstraction layer... HOT 2
- _gameLoop in tracker and game events is null HOT 2
- Post-Install Download of Original Repo HOT 2
- Cannot Parse m_timeUTC and m_timeLocalOffset HOT 3
- Not working HOT 5
- Matching BNet account HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroprotocoljs.