Comments (11)
As part of this I'd suggest updating this page:
https://github.com/Farama-Foundation/stable-retro/blob/master/docs/developing.rst
There are references to windows. I would suggest we update this to point folks to the docker file.
from stable-retro.
Thanks, we would be really interested in adding 3.10 support but looking at the release, I'm a bit confused about how the changes add support for 3.10
from stable-retro.
https://github.com/TwitchAIRacingLeague/retro/blob/v0.9.0/docker/Dockerfile#L59
-DPYTHON_INCLUDE_DIR=/usr/include/python3.10
I built with python3.10 libraries, and I can run using python3.10 on my windows machine currently.
Sorry I didn't include that added context.
from stable-retro.
I haven't tried building for Linux, but assume it will be sufficiently similar.
from stable-retro.
Ok, I'm glad that it was nothing more complex. We are interested in adding wheels for all common operating systems, we should say that Gym and gymnasium don't explicitly support Windows but we try to support it when we can
from stable-retro.
Before closing this as we did merge in my changes. Did we want to support compiling all the versions of python we'd like to support (for windows)? This update only compiles for 3.10 in windows.
I suppose additionally I should/need to add 3.10 to compile support for linux (and mac?) but I haven't done that, maybe worthwhile keeping this issue open until we sort that out.
from stable-retro.
If we have CI testing for 3.10 then I think it is fine
from stable-retro.
What do you mean if we have CI testing for 3.10 it should be fine? I am not sure if that question is in regards to mine about adding support for other versions of python. I am largely meaning, if we reach a point where pip install stable-retro is an option for windows users, we might want other versions available. (I can't recall if we just upload .whl files to pypi or what, it's been a while).
I also might just not know how it works well enough.
from stable-retro.
I thought you were talking about CI not wheels, yes, we should investigate building wheels in CI. In gymnasium we have the following code that will upload all of the build files to PyPI on github releases - https://github.com/Farama-Foundation/Gymnasium/blob/main/.github/workflows/build-publish.yml
from stable-retro.
Python3.10 on Linux works. And I think we dropped support for python3.6
from stable-retro.
Python 3.10 support work, we are missing 3.11 due to c++ errors
from stable-retro.
Related Issues (17)
- Remove Travis-Ci and GCP related code HOT 14
- Error: Could not build wheel for stable-retro HOT 2
- Integration UI Error HOT 4
- Documentation Cleanup HOT 1
- Checklist for maturity HOT 6
- UI Releases HOT 2
- Filtered Actions Documentation HOT 3
- Error when installing with git via pip HOT 2
- support double dragon Neo-Geo(MAME Emulator) ? HOT 17
- OpenAI References
- Build on windows HOT 3
- Segmentation fault when compiling integration tool HOT 3
- CI not working HOT 2
- New version issue with latest git commit HOT 3
- error: metadata-generation-failed HOT 8
- update docker windows builder.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stable-retro.