faiyaz26 / one-liner-joke Goto Github PK

They are not funny..
Any fix ?

Here are a few examples of (sexist/racist) jokes I found in this repository which should be removed or at least filtered out by the default method:

What is the difference between a black and a bucket of sh-t? The bucket.
What do you call 100 n-ggers on the bottom of the sea? A good start.
Why do bachelors like smart women? Because they're so rare.
What do u do when your sitting in the dark and your TV starts to float? You turn on the lights and shoot the black guy stealing it.

Being labelled "one-liner-joke" developers may use it as generic chatbots, or in areas where it is not acceptable (I understand the developer takes responsibility for not checking which packages it uses).

getRandomJokes({ darkHumour: false }) perhaps an option parameter, where this is false by default, or getRandomJokes({ exclude: [ "racist", "sexist" ] }).

I think some of the jokes are really good, but there are extremely controversial ones.

Thank you.

When you are checking if joke has excluded tags, you check if indexOf(...) > 0 (here https://github.com/faiyaz26/one-liner-joke/blob/master/index.js#L25 and in couple other places), which is wrong, you should be checking if indexOf(...) >= 0. As a result of this error, first excluded tag is skipped, and that means that with default settings you still allow racist jokes although you say in docs that you don't!

There are many racist jokes that are not labeled as racist. While I would vote for removing racist jokes completely, the first step is at least labeling them correctly. This jokes not being labeled correctly could be dangerous for somebody looking to generate a random joke which is suitable for work, as they might by mistake get a racist joke, even though it says in your README that by default jokes with 'racist' tag are excluded -> it doesn't however say that a lot of them are not correctly tagged.