faithoflifedev / obs_websocket Goto Github PK

File: lib/src/request/outputs.dart
line: 56

It should be change to "GetReplayBufferStatus" from "ToggleVirtualCam"

hello,
here is some feedback, it's raw note, so it could be a bit rough to read

• I'm happy it's here and it's seems more modulable ;)
• could be nice to have a mapping between command and from the list coming from the protocol and the way to call them
  • GetVersion : obsWebSocket.general.getVersion(), obsWebSocket.general.version, obsWebSocket.send('GetVersion')
• some changelog guide could a helpful plus
• I find a bit distracting to have several method to do the same thing like general.version and general.getVersion or getSourceScreenshot and getScreenshot

Bug

request

• getScreenshot method => use GetSourceActive instead of GetSourceScreenshot
• saveScreenshot method => use GetSourceActive instead of SaveSourceScreenshot
  for the request, it's seems to be all

response

• SourceScreenshotResponse : imageData is a bool instead of a string or a Uint8List
• SceneListResponse : currentPreviewSceneName could be null
  I didn't look yet to other response

event

• I don't know why yet, but ExitStarted seems to have trouble to be added in the handler

Missing element

• RequestBatch

Sorry I didn't got the time to go deeper. If I got time, I will try to make some MR. Thanks for the work

I found bug about stopRecording function at version 2.4.4.
See source lib\src\obs_websocket_base.dart line 288.
I think it should be changed to StopRecordinging -> StopRecording.

Thank you.

When running a command and the obs websocket server cannot be reached, a WebSocketChannelException is thrown, that cannot be caught.

Hello,
any plan to implements v5 of protocol?

see https://github.com/obsproject/obs-websocket/blob/release/5.0.0/docs/generated/protocol.md

thanks

Hello,
I think a nice feature using the CallVendorRequest could be a specific call for the browser.

Here is an example :

    var response = await obsWebSocket.send('CallVendorRequest', {
      'vendorName': 'obs-browser',
      'requestType': 'emit_event',
      'requestData': {
        'event_name': 'obs-websocket-test-event',
        'event_data': {'my':'data', 'that':'will be displayed in an event'},
      },
    });

    print(response.toString());
    print(response?.requestType);
    print(response?.requestId);
    print(response?.requestStatus);
    print(response?.responseData);

this will display as

flutter: {"requestType":"CallVendorRequest","requestId":"e2bd885e-a382-4090-964b-98f90a76e7f9","requestStatus":{"result":true,"code":100,"comment":null},"responseData":{"requestType":"emit_event","responseData":{},"vendorName":"obs-browser"}}
flutter: CallVendorRequest
flutter: e2bd885e-a382-4090-964b-98f90a76e7f9
flutter: {"result":true,"code":100,"comment":null}
flutter: {requestType: emit_event, responseData: {}, vendorName: obs-browser}

In the browser, we can see the result

window.addEventListener('obs-websocket-test-event', function(event) {
	console.log(event.detail) //  {"my":"data","that":"will be displayed in an event"}
})

I think that adding an event to the browser could be really interesting, because it is a plugin that is really use everywhere.

obsproject/obs-browser#340 for the browser integration

When I use sqflite I always use the singleton pattern to create an instance of the connection and return the same instance if the openDB() function is called again and again in separate query function. Is there a way we can do the same with obs-websocket?

Can we make the connection a separate methods w/ a return statement?

I've just imported this line into my code:

import 'package:obs_websocket/obs_websocket.dart';

Then the compiler warns me when I'm running on web environment:

.../.pub-cache/hosted/pub.dartlang.org/obs_websocket-2.2.12/lib/src/obs_websocket.dart:55:37:  
Error: The argument type 'WebSocket/*1*/' can't be assigned to the parameter type 'WebSocket/*2*/'.    
 - 'WebSocket/*1*/' is from 'package:universal_io/src/http/http.dart'
 ('/D:/flutter/.pub-cache/hosted/pub.dartlang.org/universal_io-2.0.4/lib/src/http/http.dart').
 - 'WebSocket/*2*/' is from 'dart:_http'.
        channel: IOWebSocketChannel(websocket), fallbackEvent: fallbackEvent);
                                    ^

Please help me this issue!

please change command "StopRecording"