CircuitBreaker broken for 0.9.3 about failsafe HOT 5 CLOSED

So this is the line that's failing?

https://github.com/sunng87/diehard/blob/master/test/diehard/core_test.clj#L185

One thing that comes to mind is that the delay might be too short for this test:

https://github.com/sunng87/diehard/blob/master/test/diehard/core_test.clj#L177

Since the circuit breaker will only be in the closed state for 10 milliseconds, the breaker might transition back to closed before the test finishes, causing the test failure. Try increasing the delay to 1 minute or something (a long delay shouldn't matter in this case) which will make sure the breaker stays in the open state for the duration of the test.

from failsafe.

Hi @jhalterman , I set delay to 100 seconds and the test still fails: https://travis-ci.org/sunng87/diehard/builds/158639725

With 0.9.2 it passes with 10ms delay.

from failsafe.

Ah, now a NullPointer :) Any chance you can print a stack trace for the NullPointerException?

from failsafe.

Got the reason. From 0.9.3, now CircuitBreakerOpenException extends FailSafeException which is a little break change:

https://github.com/jhalterman/failsafe/blob/master/src/main/java/net/jodah/failsafe/CircuitBreakerOpenException.java

I will update diehard to adapt this change.

from failsafe.

@sunng87 Thanks. I'll add a note on this change to the changelog.

The idea is that having CircuitBreakerOpenException extend FailsafeException makes the user experience a little better, so users can just catch FailsafeException if they want. I hadn't expected any breakage from this, but good to know.

from failsafe.