There's a subtle semantic difference between how FailsafeExc

Add FailsafeExecutionException extending FailsafeException for wrapping Throwables in sync get about failsafe HOT 1 OPEN

Tembrel commented on June 12, 2024

Add FailsafeExecutionException extending FailsafeException for wrapping Throwables in sync get

from failsafe.

Comments (1)

Tembrel commented on June 12, 2024

No response to this, which is fair, since it doesn't really ask any questions or propose any action, other than better documentation.

But there's a way to make things a little nicer without any compatibility issues (I think): Add FailsafeExecutionException as a subclass of FailsafeException and use it to wrap exceptions thrown during synchronous get, instead of FailsafeException. This wouldn't break any catch (FailsafeException ...) {...} blocks, but it would allow a runtime distinction between FailsafeException as wrapper vs. as superclass.

Only two FailsafeException to FailsafeExecutionException changes would be required, that I could find, here:

failsafe/core/src/main/java/dev/failsafe/SyncExecutionImpl.java

Lines 192 to 196 in 0f3f66d

    
           if (exception instanceof RuntimeException) 
        
             throw (RuntimeException) exception; 
        
           if (exception instanceof Error) 
        
             throw (Error) exception; 
        
           throw new FailsafeException(exception);

and here:

failsafe/core/src/main/java/dev/failsafe/Functions.java

Lines 272 to 276 in 0f3f66d

    
           if (e instanceof RuntimeException) 
        
             throw (RuntimeException) e; 
        
           if (e instanceof Error) 
        
             throw (Error) e; 
        
           throw new FailsafeException(e);

(Incidentally, couldn't these be consolidated?)

So I changed the issue title to reflect this proposal.

from failsafe.

Add FailsafeExecutionException extending FailsafeException for wrapping Throwables in sync get about failsafe HOT 1 OPEN

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (exception instanceof RuntimeException)
	throw (RuntimeException) exception;
	if (exception instanceof Error)
	throw (Error) exception;
	throw new FailsafeException(exception);

	if (e instanceof RuntimeException)
	throw (RuntimeException) e;
	if (e instanceof Error)
	throw (Error) e;
	throw new FailsafeException(e);