The spool-cart from fabrix-app

make POST a DELETE request

spool-cart/test/integration/2-controllers/admin/ProductController.test.js

Line 759 in e53b40f

it('should make removeImage post adminUser', (done) => {

for future deprecation: this could/should be a DELETE request

New Variant Options not propogating when a new one is added

Getting a product after adding a property to a variant doesn't get the new options array.

Repro:

Create product with no opts
Create variant with no opts
Add opt to variant
Does not reflect in parent product.

Add Remove Vendor

Issue Description

Should use vendor objects

Environment

node version: 10.0.0
fabrix version: 1.5.9
operating system: macOS/Linux

Adding multiple associations does not work

spool-cart/test/integration/2-controllers/admin/ProductController.test.js

Lines 613 to 625 in 76cccd6

    
           it('should add association to product', (done) => { 
        
             adminUser 
        
               .post(`/product/${createdProductID}/associations`) 
        
               .send(qs.stringify({ 
        
                 associations: [1, 2] 
        
               })) 
        
               .expect(200) 
        
               .end((err, res) => { 
        
                 // console.log('BROKE ASSOC', res.body) 
        
                 assert.ok(res.body.length) 
        
                 done(err) 
        
               }) 
        
           })

This test does not work in practice (not making association, returns empty array).

Update address not updating internally

spool-cart/lib/config/routes.ts

Lines 3504 to 3524 in 7320685

    
           'PUT': { 
        
             handler: 'CustomerController.updateAddress', 
        
             config: { 
        
               prefix: 'cart.prefix', 
        
               validate: { 
        
                 params: { 
        
                   id: joi.alternatives().try( 
        
                     joi.number(), 
        
                     joi.string() 
        
                   ).required(), 
        
                   address: joi.any().required() 
        
                 } 
        
               }, 
        
               app: { 
        
                 permissions: { 
        
                   resource_name: 'apiPutCustomerIdAddressAddressRoute', 
        
                   roles: ['admin'] 
        
                 } 
        
               } 
        
             } 
        
           },

also, it is not returning the updated object

Subscription Cancelling too fast.

Issue Description

Should cancel at cancellation date. Was cancelled 30 minutes after deactivating.

Environment

node version: 10
fabrix version: 1.6.0
operating system: all

`position` key not returned on collection images

Get all collection images does not return image positions or srcs, so images appear unsorted (this also could lead to issues down the line, both keys should be returned on add).

[bug] Calculated Price not Updating

Issue Description

When uploading products through the admin panel - their calculated pricing is not getting updated to the newest pricing fix, it stays the old pricing.

This affects the front-end as it shows the calculated price to be displayed - as well as this part gets carried over to the cart checkout for the calculated price vs the compare_at_price and price columns.

Environment

node version: ???
fabrix version: ???
operating system: ???

Can not delete user

spool-cart/lib/config/routes.ts

Lines 3741 to 3765 in 7320685

    
           '/customer/:id/user/:user': { 
        
             'GET': { 
        
               handler: 'CustomerController.user', 
        
               config: { 
        
                 prefix: 'cart.prefix', 
        
                 validate: { 
        
                   params: { 
        
                     id: joi.alternatives().try( 
        
                       joi.number(), 
        
                       joi.string() 
        
                     ).required(), 
        
                     user: joi.alternatives().try( 
        
                       joi.number(), 
        
                       joi.string() 
        
                     ).required() 
        
                   } 
        
                 }, 
        
                 app: { 
        
                   permissions: { 
        
                     resource_name: 'apiGetCustomerIdUserUserRoute', 
        
                     roles: ['admin'] 
        
                   } 
        
                 } 
        
               } 
        
             },

Calling this endpoint returns a 404.

Should be a DELETE call for this method

spool-cart/test/integration/2-controllers/admin/ProductController.test.js

Lines 678 to 687 in 76cccd6

    
           it('should remove association from product', (done) => { 
        
             adminUser 
        
               .post(`/product/${createdProductID}/removeAssociation/1`) 
        
               .send({}) 
        
               .expect(200) 
        
               .end((err, res) => { 
        
                 assert.equal(res.body.id, createdProductID) 
        
                 done(err) 
        
               }) 
        
           })

Variant Images not returned on get, update

Images are not being returned after being through the getVariant or getVariantImages endpoint after updating a variant through updateVariant

Missing Endpoints from NgAdmin QA

PUT /api/v1/customer/<id>/customers
DELETE /api/v1/collection/<id>/collection/<id>
DELETE http://localhost:4200/api/v1/product/<id>/variant/<variant>/images/<image>
PUT http://localhost:4200/api/v1/vendor/<id>/products
POST http://localhost:4200/api/v1/vendors

updating variant doesn't return images

Issue Description

When updating a variant, no images key is returned.

When GETing a product, the returned images array on that variant is an empty array.

Environment

node version: ???
fabrix version: ???
operating system: ???

Return associations on remove association

Issue Description

When removing an association (DELETE /product/:product/association/:association) it should also return the updated array of associations on the product (currently returns the product instance)

Environment

node version: ???
fabrix version: ???
operating system: ???

allow empty strings on property_pricing body

Issue Description

???

Environment

node version: ???
fabrix version: ???
operating system: ???

User -> Add/Remove Customer

spool-cart/lib/config/routes.ts

Lines 11612 to 11640 in 7d4e2f2

    
           '/user/:id/customers': { 
        
             'GET': { 
        
               handler: 'UserController.customers', 
        
               config: { 
        
                 prefix: 'cart.prefix', 
        
                 validate: { 
        
                   params: { 
        
                     id: joi.alternatives().try( 
        
                       joi.number(), 
        
                       joi.string() 
        
                     ).required() 
        
                   }, 
        
                   query: { 
        
                     offset: joi.number(), 
        
                     limit: joi.number(), 
        
                     sort: joi.array().items(joi.array()), 
        
                     where: joi.any(), 
        
                     include: joi.array().items(joi.string()) 
        
                   } 
        
                 }, 
        
                 app: { 
        
                   permissions: { 
        
                     resource_name: 'apiGetUserIdCustomersRoute', 
        
                     roles: ['admin'] 
        
                   } 
        
                 } 
        
               } 
        
             } 
        
           },

Endpoint	Response	Expected
Remove Image	Whole product object	removed image
Add image	does not exist	new image objects

Pricing Override not adjusting Pending Transaction

Issue Description

Pricing Override not adjusting Pending Transaction

Environment

node version: 10.0.0
fabrix version: 1.5
operating system: macOS, Linux

Put Variant Options

Issue Description

Variant Option not updated when passed as update.

Environment

node version: 1.0.0
fabrix version: 1.5.9
operating system: macOS/Linux

Property Pricing

Issue Description

On Product Variant Property Pricing Changes and Product Property Changes, the variants should all be updated.

	it('should add association to product', (done) => {
	adminUser
	.post(`/product/${createdProductID}/associations`)
	.send(qs.stringify({
	associations: [1, 2]
	}))
	.expect(200)
	.end((err, res) => {
	// console.log('BROKE ASSOC', res.body)
	assert.ok(res.body.length)
	done(err)
	})
	})

	'PUT': {
	handler: 'CustomerController.updateAddress',
	config: {
	prefix: 'cart.prefix',
	validate: {
	params: {
	id: joi.alternatives().try(
	joi.number(),
	joi.string()
	).required(),
	address: joi.any().required()
	}
	},
	app: {
	permissions: {
	resource_name: 'apiPutCustomerIdAddressAddressRoute',
	roles: ['admin']
	}
	}
	}
	},

	'/customer/:id/user/:user': {
	'GET': {
	handler: 'CustomerController.user',
	config: {
	prefix: 'cart.prefix',
	validate: {
	params: {
	id: joi.alternatives().try(
	joi.number(),
	joi.string()
	).required(),
	user: joi.alternatives().try(
	joi.number(),
	joi.string()
	).required()
	}
	},
	app: {
	permissions: {
	resource_name: 'apiGetCustomerIdUserUserRoute',
	roles: ['admin']
	}
	}
	}
	},

	it('should remove association from product', (done) => {
	adminUser
	.post(`/product/${createdProductID}/removeAssociation/1`)
	.send({})
	.expect(200)
	.end((err, res) => {
	assert.equal(res.body.id, createdProductID)
	done(err)
	})
	})

	'/user/:id/customers': {
	'GET': {
	handler: 'UserController.customers',
	config: {
	prefix: 'cart.prefix',
	validate: {
	params: {
	id: joi.alternatives().try(
	joi.number(),
	joi.string()
	).required()
	},
	query: {
	offset: joi.number(),
	limit: joi.number(),
	sort: joi.array().items(joi.array()),
	where: joi.any(),
	include: joi.array().items(joi.string())
	}
	},
	app: {
	permissions: {
	resource_name: 'apiGetUserIdCustomersRoute',
	roles: ['admin']
	}
	}
	}
	}
	},

fabrix-app / spool-cart Goto Github PK

spool-cart's People

Contributors

Stargazers

Watchers

Forkers

spool-cart's Issues

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Environment

Issue Description

Recommend Projects

Recommend Topics

Recommend Org