fabriciofx / cactoos-jdbc Goto Github PK

As we already have discussed before, I don't know if these names, like XxxToYyy are good.
Indeed, I'm not sure about them yet. But, today, I believe XxxAsYyy or XxxAdapterForYyy could be better names.

What do you think?

Server interface extends Closeable with is old and exists only for compatibility. The right way is to use AutoCloseable instead. So let's refactor it.

Let's update all dependencies.

ANTLR produces the following warning:

ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7

We should create ResultSetAsJson which will implement Scalar and returns properly formatted JSON.

Let's refactor Params to improve architectural design. It should be a interface and let's move the implementation to another class.

Let's configure pdd and 0pdd.

it would be nice to have keyset pagination here

For having reproducible unit tests, it would be very useful to employ docker-composer to create containers with MySQL, Postgres, etc.

There is no automate building provider, let's use rultor to do this automation

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

In ParsedSql class you have the following pattern
Pattern find = Pattern.compile("(?<!')(:[\w])(?!')");
Then you use substring(1) from matched strings , maybe it would be better to use this pattern instead
Pattern.compile("(?<!'):([\w])(?!')")
And then
while (matcher.find()) {
fields.add(matcher.group(1));
}

Let's change the usage of oraclejdk8 to openjdk8 in Travis CI due license issues.

Let's update Copyright notice to 2019.

In Elegant Object Vol. 2, section 6.5.6 Too many round trips, Yegor discuss about the problem of many round trips to RDBMS, to fetch data from each SQL Speaking Object (SSO). A solution to this problem is use a FakeConnection class (here it will be called Cached) that will cache all data of each SSO. But to implement a caching decorator to JDBC API it isn't trivial. We need implement a SQL parser and analyser to check each SQL statement to perform correctly (store or retrieve) data.
The API to be used by the developer should be something like:

public final class Cached implements Session {
 ...
}

final Session session = new Cached(
  new SessionAuth(
    new SourceH2l("test"),
    "foo",
    "bar")
  )
);

Travis build is currently failing with:

[WARNING] /home/travis/build/fabriciofx/cactoos-jdbc/src/test/java/com/github/fabriciofx/cactoos/jdbc/server/ServerMysqlTest.java:[42,20] auto-closeable resource com.github.fabriciofx.cactoos.jdbc.Server has a member method close() that could throw InterruptedException

This is a bug in the JDK.

... because void close() throws Exception means that InterruptedException (a child of Exception) "could" be thrown... which is the signature of AutoCloseable.

Taken from a (comment)

So the way I see it, a temporary solution is to add a default method to Server with a more specific exception type.

@amihaiemil I've read your post An Extension To TellDontAsk and I liked very much. Congratulations! So, based on it, I'm thinking change the SqlContacts code here to return a Contacts instead of a List<Contacts>. To achieve this, I must implement a FilteredContacts, as you've suggested on post. So, my doubt is: how do you think should be the constructor signature? FilteredContacts(final List<Contacts> found, final String name)?

For use it in project we should have download jar from sonatype repository.

Let's rename Param value attribute to be different of parameter value name.

Sometimes we need a sql script that containts nothing. So, let's create a ScriptSqlEmpty which represent an empty sql script.

I haven't understand this part. There is a loop and the val variable is replaced every time in the loop. Why is that?

I find it very difficult to test classes from com.github.fabriciofx.cactoos.jdbc.rset, because real data in database is required. In SelectTest.select() there is a code that can be used for that purpose. How about moving it to object that will make possible to reuse it?

Let's refactor Script and ScriptSql to improve design.

Let's implements Constraints concept to Agenda demo.

I believe this class, KeydQuery, is a typo.

Should it be KeyedQuery?