fabiospampinato / alfred-eject-workflow Goto Github PK

I noticed today that Recovery showed up as an option for me to eject. I hadn't seen this before today, so it's possible it's mounted for some reason.

Adding this to line 21 in list.js filters it out:

      if ( /^\/Volumes\/Recovery/.test ( mountpoint ) ) continue;

I'd submit a pull request, but I'm not sure you want a full binary swap as a PR for the .alfredworkflow. If you'd like me to do that though just let me know. Thanks for a great workflow!

When I use the "eject all” command, I always get a “it is now safe to remove your hardware”—even when the eject fails because a volume was being used. This caused me to mistakenly remove a hard drive that was in use, leading to it becoming corrupted (don’t worry, no data loss!). umount gives an error code in this case, so it should be straightforward to give a different notification if the command fails, right?

Hi @fabiospampinato,

Thank you for making this useful workflow!

I tried installing it, but couldn't get it to work straight away: after typing eject , a list of drives didn't appear. After looking at the workflow, I noticed that a NodeJS script is used to generate this list.

Can you list NodeJS as a dependency in the readme, for other people running into the same problem?