Codacy detected an issue:

Message: [no-file-name-irregular-characters] Do not use _ in a file name

Currently on:

• Commit: 09c451c
• File: .github/ISSUE_TEMPLATE/bug_report.md
• LineNum: 1

Describe the bug

We're testing this plugin with Netlify and Nx, and it seems to work fine for sites that have already had a deploy before adding this plugin, but for a new site it doesn't seem to allow any builds through. I'm assuming that this is because nx print-affected isn't getting a base commit? The base commit comes from process.env.CACHED_COMMIT_REF but is there a chance that this environment variable isn't set to anything when the site hasn't had a successful build?

If it's not set, it seems that the nx print-affected command will throw an error (with exit code 1). If the command fails, does execution continue as if the project is unaffected?

Steps to reproduce

I believe this happens just to new sites that haven't had a successful build when the plugin runs, but haven't confirmed.

Expected behavior

I'd expect the plugin to allow the build to finish if the nx print-affected command fails for any reason.

I'll try to deploy a local version of the plugin to test further.

Thanks a lot for this plugin!

The README is good but quite concise. What are your thoughts on adding more instructions in the README for users?
The following documentation has several ideas which might be helpful for this. What do you think?

Netlify Build is using the bugs field from package.json to let plugin users file bugs directly. Would it be ok to add that field? Thanks!

The current logic to retrieve the project name currently fails in the following situations:

• On Windows, the file path is \, so

  netlify-plugin-nx-skip-build/src/index.js

  Line 21 in bab8bdf

  const [name] = dir.split('/').reverse()

  does not work.
• Although PUBLISH_DIR is currently never ending with a /, this might change in the future. If this was to change, the current logic would return an empty string.

As a small additional note, constants.PUBLISH_DIR is always defined, so no default value is needed.

I believe the following code might solve those problems:

const { basename } = require('path')

const projectName = basename(constants.PUBLISH_DIR)

What do you think?

Additional question: does this code work with the two following situations?

• By default, the publish directory is the repository root directory, i.e. projectName will most likely be the repository name.
• However, users can configure the publish directory. In that case, projectName will be the publish directory filename.

Thanks for suggesting a new feature!

Please fill in the sections below.

Which problem is this feature request solving?

For example, I'm always frustrated when trying to redeploy my site with no code changes, so the plugin prevents me from doing this.

Describe the solution you'd like

Example: This could be fixed by skipping the check if the site is deploying manually either the Netlfiy website or CLI.

Describe alternatives you've considered

Example: Another solution would be listening to the env variable like MANUAL_DEPLOYMENT to true, so we can skip the logic if it is true.

Can you submit a pull request?

Yes, Soon.