The current content of the default favicon.ico is probably not intended about serve-favicon HOT 8 CLOSED

I updated the comment to actually reflect the content. Looks like the favicon.ico file is actually some HTML.

from serve-favicon.

Thanks. I closed the issue cause I had no clue what it was about from the title. We just need to grab the correct raw favicon. Actually scratch that. We should just remove the default favicon. Useless to have it anyway.

from serve-favicon.

Yea, I also had no idea what the original issue meant, either :) Yes, I think we should simply require the icon path to be specified and throw if not. Perhaps that can be released as 2.0.0 or something :D

from serve-favicon.

@defunctzombie can you push 1.0.2 to npm, please :)? I can then get this worked into connect 2.5.x

from serve-favicon.

Sorry. I'll try to be more explicit next time. Thank you for the quick fix

from serve-favicon.

aw should've made the default icon doge

from serve-favicon.

published

from serve-favicon.

@jonathanong :P now that we have a "working" 1.x, we should change it to remove the default icon and simply release it as 2.x

from serve-favicon.