Comments (4)
Hello, and sorry for any trouble. Can you expand on what doesn't work, exactly? Perhaps some replication steps so we can try and figure out what is going on? This module just takes the icon you give it and serves it at the path /favicon.ico
; if you need to include any specific HTML that is of course beyond what this module can add for you, though you can point it to the path thia module seves it under (and get the benefits of zero disk access still).
from serve-favicon.
Hi, there's little more I can add here.
I created a favicon.ico from an image with one of these favicon pages which you find by Goodle search. I can't remember exactly which one it was. It created a 48x48 favicon.ico (I would have attached it here but file attachment here seem to be not possible).
I installed your npm module and added it using the Express sample code. It showed up immediately on Firefox and Edge. But no success on Chrome even after a lot of reloading and Cache refresh hazzle. There even was no request for the icon visible in Dev tools.
Then I tried the page referenced in my first comment which created a lot of file variants and proposed a lot of link entries as well, which I all added to my app. Doing so it worked immediately. In the Dev tools screenshot below you see that Chrome (here: Windows) requests one of the file variants rather than favicon.ico.
Hope this helps. Thanks for your interest!
from serve-favicon.
Gotcha. Unfortunately it sounds like that is just out of scope of thia module. At the top of thw readme it notea that this is only for the favicon.ico file and any additional files of HTML markup, you'll want to use serve-static module.
from serve-favicon.
I read your README note again (and actually now I understand the impact) and understand your point.
I just want to add my personal opinion that from a user's point of view, a solution which doesn't work for the typical browsers like Chrome is NOT a true solution, even if in earlier times the plain favicon.ico file might have been the solution for all browsers. Shame for Chrome if they might have things complicated since then, but ...,
It would users save time, if you would change your note in the sense that today just serving the favicon,ico is no longer sufficient for working with all browsers. So interested users could then immediately head to other solution pages.
Thanks for clearing this up.
from serve-favicon.
Related Issues (20)
- Purpose HOT 3
- Performance HOT 2
- where do i get the favicon icon ? HOT 1
- Support Requirement for Multiple Favicons HOT 4
- doc typo HOT 1
- serving different favicon for different pages HOT 1
- If no favicon present, should just return a 404 HOT 13
- Possible to use location outside of your repo? HOT 4
- Can't see favicon when using Microsoft Edge HOT 2
- Vary favicon by domain HOT 4
- Doubts on res._headers HOT 3
- Favicon not showing when running server with long context path. HOT 5
- How to use png favicon files? HOT 1
- how can I use a url instead of path? HOT 4
- how to add different favicon for different routers? HOT 3
- serve-favicon vulnerable to RegEx Denial of Service attack HOT 1
- Favicon is not showing HOT 5
- Can't run express js server app on my local host:3000 HOT 4
- Feature Request: Serve icon based on host mapping HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serve-favicon.