executablebooks / web-compile Goto Github PK

Describe the bug

There is a bug in Jinja2 v2 with the newer release of MarkupSafe from 2.0 to 2.1. If you install Jinja2 version 2.11.3, as is pinned in web-compile's setup.py, it will install MarkupSafe 2.1.1. This will lead to an error when you import Jinja2.

Reproduce the bug

1. Create a Python environment with Jinja 2.11.3 installed:

   $ conda create --name test python=3.8 jinja2=2.11.3

2. Run the python interpreter and import jinja2:

   $ python

3. Import jinja2:

   >>> import jinja2
     File "/Users/kpaul/Software/miniconda3/envs/webcompile/lib/python3.10/site-packages/jinja2/__init__.py", line 12, in <module>
       from .environment import Environment
     File "/Users/kpaul/Software/miniconda3/envs/webcompile/lib/python3.10/site-packages/jinja2/environment.py", line 25, in <module>
       from .defaults import BLOCK_END_STRING
     File "/Users/kpaul/Software/miniconda3/envs/webcompile/lib/python3.10/site-packages/jinja2/defaults.py", line 3, in <module>
       from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F401
     File "/Users/kpaul/Software/miniconda3/envs/webcompile/lib/python3.10/site-packages/jinja2/filters.py", line 13, in <module>
       from markupsafe import soft_unicode
     ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/Users/kpaul/Software/miniconda3/envs/webcompile/lib/python3.10/site-packages/markupsafe/__init__.py)

Alternatively, you can simply create a python environment with web-compile installed and try running web-compile from the command-line. The same error will occur.

List your environment

Python: 3.8
Jinja2: 2.11.3
MarkupSafe: 2.1.1

We should make a PR here https://github.com/pre-commit/pre-commit.com to make scss-compile appear on https://pre-commit.com/hooks.html