Windows requires package source? about puppet-puppet HOT 5 CLOSED

Honestly I'm not using Puppet on Windows and have not much experience on it, I think that Chocolatey is the choice of reference when managing packages on Windows, so I would take it for granted and present when trying to support Windows on the modules.

from puppet-puppet.

Ok. I'll work on a patch. I may also follow up with patches for the monitoring integration.

from puppet-puppet.

So as a followup on this, it does seem that when we have example42/puppi, example42/puppet-monitor, and example42/puppet-puppet installed with the latest versions, things work well on Windows. The one issue I did encounter was what seems to me to be a logic problem in example42/puppet-puppet/manifests/init.pp:854:

### Service monitoring, if enabled ( monitor => true )
if $puppet::monitor_tool and $puppet::runmode == 'service' {

I would think this ought to test $puppet::monitor instead of (or in addition to) $puppet::monitor_tool, what do you think? The case I ran into is when $puppet::monitor is false, but the node inherits $puppet::monitor_tool from the global $::monitor_tool. This causes a windows machine to want to install example42/puppet-nrpe when $::monitor_tool = 'nagios'.

I'm going to continue to investigate extending the monitor subsystem (at least for nagios/icinga) to help windows use the NSCA client instead of NRPE, but I've got a long way to go on that.

from puppet-puppet.

Yes, you are right, ty

from puppet-puppet.

Thanks, I'll close this issue, my initial hurdles have all been conquered!

from puppet-puppet.