ewinslow / elgg-evan Goto Github PK

Otherwise people end up submitting twice.

Lots of routes are available and added, but many more still need to be added and many need to be fixed.

• Messages inbox
• User settings
• Search
• Members listing

The menu system is configured in PHP and not javascript right now. That makes it hard to respect the PHP choices from the menu

They seem to be doing the same thing? I can't even remember now. One was probably a rewrite of the other.

Right now we pass a lot of options/config around as arrays. This lends itself to subtle typos and doesn't have the benefit of IDE autocomplete, early errors, etc.

Instead of:

elgg_register_menu_item('menu', MenuItem::factory(array(
  'name' => 'foo',
  'href' => '/bar',
  'text' => 'etc',
)));

We could have a builder:

elgg_register_menu_item('menu', MenuItem::create('foo')
  ->href('/bar')
  ->text('etc')
);

This would also give us a nice way to define our API more explicitly/cleanly/thoroughly, because the builder would be a class/interface with all the options listed. It's also basically as terse as the array syntax so there shouldn't be any extra "bloat" from making it a class, besides perhaps that initial MenuItem::create stuff.

It's frustrating to have to do it manually, and doing it manually isn't very plugin friendly either. If a plugin just wants to update the template, they have to override ngDeps to add new dependencies, but if another plugin decides to override the Controller, it also now has to override ngDeps to include modules for the Controller's required services. This breaks the template override.

Right now we require all supported plugins to be enabled in order to use this framework. Instead, we should be able to toggle the relevant routes with the associated plugin.

I.e. if the photos plugin is disabled, we should still work, but with the photo URL support removed.