ewasm / evm2wasm Goto Github PK

Version 10.0.3 of standard just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As standard is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

See https://en.wikipedia.org/wiki/Karatsuba_algorithm

The standard deploy (copycode) and Solidity's dispatcher is the bare minimum code included in every Solidity compiled code.

Example:

contract WASMTest {
    function() {
        throw;
    }
}

Compiles to: 606060405260188060106000396000f360606040523615600d57600d565b60165b6002565b565b00

This requires the following opcodes:

• STOP
• ISZERO
• CALLDATASIZE
• CODECOPY
• MSTORE
• JUMP
• JUMPI
• JUMPDEST
• PUSH
• DUP
• RETURN

It is probably a good idea supporting these first.

This should be good enough to determine that all code paths of the transcompiler are used.

Goal would be to replace constant arithmetic patterns, such as:

• PUSH X, PUSH Y, EXP -> PUSH X**Y, PUSH X, PUSH Y, ADD -> PUSH X+Y, etc.
• PUSH X, POP -> remove
• PUSH X, PUSH 0, EQ -> PUSH X, ISZERO
• see the other rules in solidity/libevmasm

It is true that Solidity will do these optimisations, but:

• The optimiser can be turned off (and certain contracts are deployed without optimisations)
• The optimiser in Solidity might miss some of these optimisations in certain versions

In order to support MSTORE/MLOAD we need to properly manage memory.

A simplistic approach is to allocate the first 32768 bytes of memory for the stack (stack limit is 1024 items, 256 bits each). The memory for MSTORE/MLOAD then starts from offset 32768.

Alternatively the opcodes themselves could have a parameter for memory offset. This should be calculated by the transcompiler.

Version 2.2.0 of ethereumjs-vm just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ethereumjs-vm is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

It would be really nice to have some unit tests for these to improve our test coverage. a basic test case for each option would suffice.

The biggest one could be introducing pseudo-EVM opcodes for shifting (or maybe with time they won't be psuedo, see ethereum/EIPs#145) and replace MUL / DIV / SDIV with two's exponent with appropriate shifts.

Use it to store/retrieve test env values.

Needed for support opcodes which call out to the environment, such as CALLDATASIZE, CALL, RETURN, etc.

https://github.com/ewasm/evm2wasm/blob/master/index.js#L425

evm2wasm support a version of stack tracing using the evmStackTrace method (https://github.com/ewasm/ewasm-kernel/blob/master/debugInterface.js#L30-L40).

This will now be extended to support the "official tracing format": ewasm/hera#114

It can be turned on by the opts.stacktrace flag in evm2wasm - this should be documented.

Needed for opcodes like CALL/RETURN/etc.

Operations should ensure that the stack limit (1024 entries) is not exceeded.

See ethereum/aleth@7a13f82

This one test is failing in the current master branch (e050d24):

evm2wasm/ master> npm run vmTests
> [email protected] vmTests /Users/lanerettig/wip/eth/evm2wasm
> node --expose-wasm --harmony ./tests/runVmTests.js
TAP version 13
# VMTESTS
...
# manyFunctions100 manyFunctions100
not ok 1425 Error: Command failed: /Users/lanerettig/wip/eth/evm2wasm/tools/wabt/bin/wat2wasm /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wast -o /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wasm
  ---
    operator: fail
    at: runner.catch.err (/Users/lanerettig/wip/eth/evm2wasm/tests/runVmTests.js:171:9)
    stack: |-
      Error: Error: Command failed: /Users/lanerettig/wip/eth/evm2wasm/tools/wabt/bin/wat2wasm /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wast -o /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wasm

          at Test.assert [as _assert] (/Users/lanerettig/wip/eth/evm2wasm/node_modules/tape/lib/test.js:225:54)
          at Test.bound [as _assert] (/Users/lanerettig/wip/eth/evm2wasm/node_modules/tape/lib/test.js:77:32)
          at Test.fail (/Users/lanerettig/wip/eth/evm2wasm/node_modules/tape/lib/test.js:318:10)
          at Test.bound [as fail] (/Users/lanerettig/wip/eth/evm2wasm/node_modules/tape/lib/test.js:77:32)
          at runner.catch.err (/Users/lanerettig/wip/eth/evm2wasm/tests/runVmTests.js:171:9)
          at <anonymous>
  ...

Attempting to run this command manually produces:

~/wip/eth/evm2wasm master> /Users/lanerettig/wip/eth/evm2wasm/tools/wabt/bin/wat2wasm /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wast -o /Users/lanerettig/wip/eth/evm2wasm/tmp/manyFunctions100.wasm
[1]    48249 segmentation fault  /Users/lanerettig/wip/eth/evm2wasm/tools/wabt/bin/wat2wasm  -o

The identity contract is used for a cheap way of memory copy (gas cost 15 + length/32*3). We could detect a call to it during transcompilation and use a wasm based memcpy.

Drawback is it introduces the need for static analysis to find the parameters on the stack first.

Version 5.1.3 of ethereumjs-util was just published.

This version is covered by your current version range and after updating it in your project the build failed.

ethereumjs-util is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Requiring every Ethereum node implementation to rewrite this Javascript project in their language of choice seems unrealistic.

Perhaps making this project available as a WASM piece of code makes sense, given WASM must be supported by nodes.

Ultimately for reducing/removing issues regarding consensus, this project should be deployed as a smart contract and invoked as such.

• CREATE
• CALL
• CALLCODE
• DELEGATECALL
• SELFDESTRUCT
• SHA3
• LOG*
• GAS
• GASPRICE
• EXTCODECOPY
• PC
• ORIGIN
• STOP
• ADD
• MUL
• SUB
• DIV
• SDIV
• MOD
• SMOD
• ADDMOD
• MULMOD
• EXP
• SIGNEXTEND
• LT
• GT
• SLT
• SGT
• EQ
• ISZERO
• AND
• OR
• XOR
• NOT
• BYTE
• ADDRESS
• BALANCE
• CALLER
• CALLVALUE
• CALLDATALOAD
• CALLDATASIZE
• CALLDATACOPY
• CODESIZE
• CODECOPY
• EXTCODESIZE
• BLOCKHASH
• COINBASE
• TIMESTAMP
• NUMBER
• DIFFICULTY
• GASLIMIT
• POP
• MLOAD
• MSTORE
• MSTORE8
• SLOAD
• SSTORE
• JUMP
• JUMPI
• MSIZE
• JUMPDEST
• PUSH*
• DUP*
• SWAP*
• RETURN

• revert
• returndatasize
• returndatacopy
• staticcall

See ethereum/yellowpaper#257

Logging this to track the conversation yesterday in gitter:

@axic Mar 21 18:38 very likely evm2was has endianess issues
@hugo-dc Mar 21 18:52 i’ve just confirmed storage is the problem, fill the tests expecting "0x" : “0x0200000000000000000000000000000000000000000000000000000000000000” in storage, and the test case pass
@jwasinger Mar 21 19:19 I have the fix. the endianness is being flipped by bswap_m256 : ;; generated by ./wasm/generateInterface.js\n(func $SSTORE (call $storageStore(call $bswap_m256 (get_global $sp))(call $bswap_m256 (i32.add (get_global $sp) (i32.const -32)))))

Tests should be run for every opcode

EXP uses floating point for gas calculation: https://github.com/ewasm/evm2wasm/blob/master/wasm/EXP.wast#L81-L82

This should be removed as the spec currently just disables floating point (the code in question should still be deterministic, but it is quite easy to replace it with non-floating point).

Ensure consistent, readable style

1 that is unreachable for mem checks
2 2^31-1 for things calldata/code interface imports

Gas costs are still set at Homestead. Need to apply Spurious Dragon and Tangerine Whistle changes.

Version 4.8.0 of tape just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As tape is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Would be a nice demonstration to use Mango. It requires the following opcodes:

• ADD
• AND
• CALL
• CALLDATACOPY
• CALLDATALOAD
• CALLDATASIZE
• CALLER
• CODECOPY
• CODESIZE
• DIV
• DUP*
• EQ
• EXP
• GT
• ISZERO
• JUMP
• JUMPDEST
• JUMPI
• LT
• MLOAD
• MSTORE
• MUL
• NOT
• OR
• POP
• PUSH*
• RETURN
• SHA3
• SLOAD
• SSTORE
• STOP
• SUB
• SWAP*

Here is a full trace of the test case callcall_00:

jwasinger@certification-hive-test03:~/projects/cpp-ethereum/build$ ETHEREUM_TEST_PATH="../../tests" test/testeth -t GeneralStateTests/stCallCodes -- --vm hera --singlenet "Byzantium" --singletest 'callcall_00' --evmc evm2wasm.js=true --evmc fallback=false
Running 1 test case...
Test Case "stCallCodes":
100%
Executing...
importGlobals
evmTrace
{"depth":0,"gas":2979000,"gasCost":0,"op":96,"pc":0,"stack":[]}
useGas 3
evmTrace
{"depth":0,"gas":2978997,"gasCost":3,"op":96,"pc":2,"stack":["0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978994,"gasCost":6,"op":96,"pc":4,"stack":["0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978991,"gasCost":9,"op":96,"pc":6,"stack":["0x0000000000000000000000000000000000000000000000000000000000000040","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978988,"gasCost":12,"op":96,"pc":8,"stack":["0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978985,"gasCost":15,"op":115,"pc":10,"stack":["0x0000000000000000000000000000000000000000000000000000000000000001","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978982,"gasCost":18,"op":98,"pc":31,"stack":["0x0000000000000000000000001000000000000000000000000000000000000001","0x0000000000000000000000000000000000000000000000000000000000000001","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 3
evmTrace
{"depth":0,"gas":2978979,"gasCost":21,"op":241,"pc":35,"stack":["0x0000000000000000000000000000000000000000000000000000000000055730","0x0000000000000000000000001000000000000000000000000000000000000001","0x0000000000000000000000000000000000000000000000000000000000000001","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000000000000000000000000000000000000000000000000000000000000040"]}
useGas 0
useGas 6
InternalError: Value exceeds 64 bits.
testeth: /home/jwasinger/projects/cpp-ethereum/libevm/EVMC.cpp:77: virtual dev::eth::owning_bytes_ref dev::eth::EVMC::exec(dev::u256&, dev::eth::ExtVMFace&, const OnOpFunc&): Assertion `r.status() >= 0' failed.
unknown location(0): fatal error: in "GeneralStateTests/stCallCodes": signal: SIGABRT (application abort requested)

The execution is compatible with Geth until after the CALLCODE op is executed.

It would be nice to have consistent local names across the wasm files

Version 2.6.0 of async was just published.

This version is covered by your current version range and after updating it in your project the build failed.

async is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Depends on ewasm/wast2wasm#9

In many cases it should be possible to write the return values directly to the stack.

• ADDRESS
• CALLER
• SHA3

Per @cdetrio:

stack pointer starting at -32 https://github.com/ewasm/evm2wasm/blob/master/index.js#L509

this whole thing needs to be moved up, because the trace should print before the instruction executes (standardized trace). where it is now, it prints after the first instruction https://github.com/ewasm/evm2wasm/blob/master/index.js#L319-L322

Cf. ewasm/hera#164

Needed for opcodes like PUSH/DUP/SWAP

• return values have been changed
• return value isn't written to be a paramater but retrieved via returndatacopy

Some values need to be tested on the output (return value, gas left, etc.)

Currently environment is hard coded as input and the return value has its own wrapper and field (return - see https://github.com/ewasm/evm2wasm/blob/master/tests/opcodeRunner.js#L83).

Version 4.11.8 of bn.js just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As bn.js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

See ethereum/EIPs#150.

It should match the costs of Byzantium exactly.