ewal / kitty-everforest Goto Github PK

Hi there,

I've been using Everforest Dark Hard as my Kitty theme now for a bit and I'm really liking it so far.
It would be cool if this project could also provide a set of color values for the diff kitten, which completely ignores the base Kitty theme. For the syntax highlighting, one of the built-in pygment styles will probably suffice, though it is also possible to create a custom one based on the original VIM theme.

While looking into the collection of upstream color themes for Kitty, I noticed that somebody had already contributed variations of the Everforest color scheme. So first of all, thanks a lot for this! 🙌

I noticed that a few of the 16 base colors were misused though. Here are a few examples, illustrated in the screenshot(s) below:

• black and foreground are the same.

  Problem: This should never be the case in a terminal color scheme, because it can render some text invisible.

  Fix: strictly stick to the fg color defined in the scheme's palette2, which is for foreground colors. You may also notice that palette2 remains the same in all hard, medium and soft variations of the scheme.

• in the dark theme, base colors are bright, bright colors are not

  Problem: These are semantically reversed. A bright color shouldn't be darker than its non-bright counterpart.

  Fix: see next point

• Foreground colors are arbitrarily selected from either the dark or light palette

  Problem: Probably my biggest concern with the current version of this Kitty theme. After inspecting the different colors, I realized that they have been selected arbitrarily from both the dark and light variants of the scheme's palette2, which explains the previous point. In the original color scheme, colors from each variant are strictly defined in palette1 + palette2. The dark variant doesn't "borrow" colors from the light variant, and vice versa. This makes this theme a custom interpretation of Everforest, but not a strict port of the original Vim Everforest colors.

  Fix: only use colors from the "dark" palette1 + palette2 in the dark themes, only use colors from the "light" palette1 + palette2 in the light theme.

I have "fixed" versions of all 6 variants locally, but before submitting a PR I wanted to share the result with you, and ask whether you would be willing to accept those changes.

before

after