Code Monkey home page Code Monkey logo

Comments (22)

evshiron avatar evshiron commented on July 17, 2024 1

@nicklaw5 --output-name is added in nwjs-builder 1.10.5. The feature is powered by string-template and in your situation --output-name "{name}-v{version}-{target}" should do the trick.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

--with-ffmpeg is added now. What about --side-by-side, which doesn't combine app.nw to the executable?

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

--side-by-side is added too in c2004af.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

Propose: --production, which doesn't copy the node_modules, but execute npm install --production when copying is done, which will strip devDependencies out and reduce file size.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

--production is added in 039e866.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

Propose: --win-ico and --osx-icns.

from nwjs-builder.

nicklaw5 avatar nicklaw5 commented on July 17, 2024

-o, --buildDir <buildPath> The build folder [default: "./build"]

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@nicklaw5 Thanks for the suggestion, added in 820718d. README and published version are also updated.

from nwjs-builder.

conceptualspace avatar conceptualspace commented on July 17, 2024

+1 for icons

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@conceptualspace --win-ico and --mac-icns are added long ago. Feel free to try them out and feedback is appreciated.

from nwjs-builder.

conceptualspace avatar conceptualspace commented on July 17, 2024

will do! and thanks for your work on this

from nwjs-builder.

MaestroJurko avatar MaestroJurko commented on July 17, 2024

Can you please update README with all the options that are available.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@mato75 I think all the options are listed in the "Usage" section. If you want a reference, please see test/test-module.js.

from nwjs-builder.

MaestroJurko avatar MaestroJurko commented on July 17, 2024

Options that would be awesome to have:

argv: [], // custom arguments passed to nwjs
port: 1245 // custom port on which nwjs is running

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

What the port means? Is it for --remote-debugging? It's a good proposition though. I will consider adding it in the next days.

from nwjs-builder.

MaestroJurko avatar MaestroJurko commented on July 17, 2024

Yes for remote debugging. I am using nwjs for testing and connecting chrome-remote-interface to it.

And also custom arguments are really useful. I am using it with web sockets.

Maybe instead of setting every available setting as an option, set argv, and user will have to add them on its own (---remote-debugging, --allow-running-insecure-content, ...) and library only reads the argv option.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

I will see how the underlying commander.js supports this.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@mato75 Custom arguments should be usable in nwjs-builder 1.10.0. There are examples in README and test/test-nwbuild.js. Feel free to try it out.

from nwjs-builder.

MaestroJurko avatar MaestroJurko commented on July 17, 2024

How do you set them when used inside *.js (I dont see an extra option, that will allow me to add custom arguments)?

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@mato75 This should work:

const NWB = require('nwjs-builder');

NWB.commands.nwbuild(['--remote-debugging-port=9222', './build/', '-a', 'bbb'], {
    run: true
}, (err, code) => {});

from nwjs-builder.

nicklaw5 avatar nicklaw5 commented on July 17, 2024

Would be great if there was an option to include the version number in the build folder name.

For example, stryve-v0.3.0-win-x64 rather than just stryve-win-x64

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

I am closing this issue now as it's too long. If there is any proposition, feel free to open a new issue.

from nwjs-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.