Code Monkey home page Code Monkey logo

Comments (6)

evshiron avatar evshiron commented on July 17, 2024

The "Copyright" is affected by the line at https://github.com/evshiron/nwjs-builder/blob/master/lib/build/win32.js#L227. Currently it's set only when we have a author property in the package.json. If you want custom copyright string rather than Copyright @ ${ author }, let me know.
I was in the second issue as well, but it came out to be an issue with node.js 4.0.0, whose streaming is broken somewhere. node.js 4.1+ works just fine. Please try unzipping the combined .exe and see if the unzipping works without any errors. If error occurs and you are using node.js 4.0.0, upgrade it and try again. If it still fails, tell me your environment and I will have a look in it.

from nwjs-builder.

darshanshankar avatar darshanshankar commented on July 17, 2024

Ah, ok the author property fixes the copyright which is fine for me.

The Company is still the default one for NW.js, and it appears on hover of the .exe.

image

Shows up in Resource Hacker as the CompanyName field.

image

And for the second issue (side-by-side packaging), I'll take a look later tonight. FWIW, I'm on node 4.4.0.

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

Glad to hear that. BTW nwjs-builder has just upgraded to 1.6.0, which accepts a nwjsBuilder property in the package.json, that should help you with the company name. See #12 for detail :)

from nwjs-builder.

darshanshankar avatar darshanshankar commented on July 17, 2024

Ah that's perfect, exactly what I was looking for. Thanks!

from nwjs-builder.

darshanshankar avatar darshanshankar commented on July 17, 2024

Please try unzipping the combined .exe and see if the unzipping works without any errors.

By the way, I tried unzipping (on win10 x64) Getting a checksum error when using 7zip to unzip it. Any idea why that could be?

from nwjs-builder.

evshiron avatar evshiron commented on July 17, 2024

@darshanshankar Thanks for the report. I will look into it. It might be better if you open another issue for it :)

from nwjs-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.