europia79 / bukkitinterface Goto Github PK

BukkitInterface causes BattleArena build to fail with a fresh, empty local-repo:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:03 min
[INFO] Finished at: 2018-12-18T20:38:53-06:00
[INFO] Final Memory: 14M/390M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project BattleArena:
Could not resolve dependencies for project mc.alk:BattleArena:jar:3.9.10.21:
Failed to collect dependencies at mc.euro:BukkitInterface:jar:4.0.1:
Failed to read artifact descriptor for mc.euro:BukkitInterface:jar:4.0.1:
Could not find artifact mc.euro:BukkitInterface-Parent:pom:parent in rainbowcraft-repo (http://rainbowcraft.sytes.net/maven/repository/) -> [Help 1]
[ERROR]

Maven is looking for the Parent pom.xml of multi-module projects when the final JAR should suffice.

BattleArena has THREE of these multi-module projects as dependencies:
https://github.com/Europia79/BukkitInterface
https://github.com/BattlePlugins/BattleBukkitLib
https://github.com/BattlePlugins/WorldEditUtil

These multi-module projects are mis-configured.

Hack#1:
Obviously, we can just deploy ALL modules & call it a day...
But these other modules don't have life-cycles...
Meaning that they're not used at all... except to create the final JAR.

Hack#2:
We can delete the Parent-block from modules/BukkitInterface/pom.xml:
This fixes the issue & Maven will no longer look for the Parent-POM.
However, this is not a real solution because the Parent-block just denotes inheritance.

Hack#3:
We can use the flatten-maven-plugin:
https://www.mojohaus.org/flatten-maven-plugin/

This essentially allows you to use your parent POMs during builds but
deletes the reference to them when your artifact gets deployed,
integrating the information from the parents at the appropriate places
(flattening), reducing the information "leaked" to the consumer of your
artifact to the bare minimum. ~Wolf