Reach full test coverage about ethereumjs-util HOT 7 CLOSED

• defineProperties is something i'm not really satisfied with. It attaches an Array of properties to an object with setters that perform validation. I think this should be pulled out to it own module or find a module to replace this function.
• printBA - just prints an array of buffers, this is a debugging function... maybe we should move it to ethereumjs-testing
• baToJSON - Also created for debugging but it has production use cases, use definitely needs a test

from ethereumjs-util.

2b7bf63 adds tests for baToJSON

from ethereumjs-util.

meeh i'm just scrapping printBA its pretty much worthless at this point

from ethereumjs-util.

baToJSON (it doesn't even return JSON, only if the input is an Array) seems so specific for defineProperties, shouldn't that be internal to it?

from ethereumjs-util.

I have used it for debugging and creating text dumps, so thats why its not internal.

from ethereumjs-util.

I'm looking at json-schema to replace the validation done by defineProps

from ethereumjs-util.

done! i ended up just writing test for defineFields

from ethereumjs-util.