Comments (2)
holgerd77
commented on May 27, 2024
Ok, I think we should move forward here, seems that this won't settle out so quickly, and this would otherwise too much of a blocker.
Seems to me that the additional interoperability risk introduced by mixing up the BN.js versions is not worth the upgrade right now. I would therefore have a stronger tendency to downgrade again. Any comments here?
And should we just go for 2. (see above, so a v7.0.1 patch release with a downgraded version), or is it worth respectively would it be cleaner to "burn" the v7.x major release number and directly go up to 8?
from ethereumjs-util.
holgerd77
commented on May 27, 2024
Ok, after @ryanio tried various things from fixing respectively injecting the missing strip() method here on our side to experimenting with further upstream fixes on the BN.js library I would very much suggest to give this a cut now and move on, and rather on the more conservative side of things.
@ryanio suggested to do the V7.0.1 fix (so version 2 from the above), I also still have got some sympathy for that so I would prepare an according PR. Phew.
from ethereumjs-util.
Related Issues (20)
- Split tests from index.js into separate files HOT 3
- Update TypeDoc and typedoc-plugin-markdown dev dependencies
- Examples in README for different categories
- Add basic API tests for re-exports
- Browser compatible elliptic alternative to secp256k1 HOT 2
- Buffer error with keccak256 related to abi.encodePacked HOT 8
- Crashes on node:12-alpine HOT 3
- [bug] hash.ts not work on alpine linux image HOT 2
- BN re-export failure HOT 1
- Error: Expected private key to be an Uint8Array HOT 8
- Node crashes when require ethereumjs-util in worker threads HOT 5
- Extend Address class to handle BN HOT 7
- Cannot read property 'fromRpcSig' of undefined HOT 2
- Memory leak HOT 2
- How to use ecrecover? HOT 8
- bnToRlp: misleading name HOT 1
- Upgrade ethereumjs-config to v2, switch from Coveralls to CodeCov
- ethereumjs-util v8 Release Planning HOT 1
- housekeeping: remove use of deprecated assert methods HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereumjs-util.