ether / ep_align Goto Github PK

When using the "Clear Authorship Colours" button, Etherpad responds with "RangeError: Uncaught RangeError: selection starts before line start".

Steps to reproduce:

• Create a new pad on https://rich.etherpad.com/
• Center the first line
• Click on "Clear Authorship Colours"

A quick "fix" is to press CTRL + A and then use the "Clear Authorship Colours" button.

@JohnMcLear Could you please update plugin version in npm.

same with ordered / numbered list.

In NPM no license shows up in the right column under License

and in main text it says something had been copied over from headings

I would suggest adding the license like it is available on github.

Ctrl L (left),
Ctrl J (justify),
Ctrl E (center),
Ctrl R (right)

With both headings and ep_align installed, if you mod text with one or the other, the other can't mod the same text. Maybe combine them into one plugin?

Steps to Reproduce:

1. Clone etherpad-lite
2. Install ep_align plugin
3. open a new pad with default text
4. click such that your caret is at the starting of first line just before "welcome".
5. click on center align button, text gets center aligned.
6. now click anywhere on the same line "Welcome to Etherpad!". You will notice that caret automatically moves to the left till it reaches the starting position.

I have a locale file but I keep getting this warning in console.

System

OS: Windows as well as iOS and Linux
Browser: Firefox 76
Etherpad: Version 1.8.3

Problem Description

Align "justify" doesn't work anymore with the new version. This is sad as it's supposed to be the most important align functionality. Still works under Chrome!

King regards, Flo

Hello,
First I want to thank you because you do a good job. Your plugin works very well on my etherpad server. There is just a little issue. When I create a paragraph and define it's formatting to "justify", it works on Chromium, Vivaldi, Chrome (to my mind, every blink-based browser), but on firefox, it doesn't work.
I hope you will correct it soon, this plugin is just awesome !
This is the "correct" result which can be seen on Vivaldi :

This is the "uncorrect", which is displayed on firefox :

Have a nice day, please forgive my english.

For the read-only version of a pad, normally all formatting buttons are not visible. The four buttons of the ep_align plugin remain visible however.

It would be great and more useful to display a Button Icon in the Button bar instead of the Text which clutters the "Button" Bar. A click on the Button could open up the Menu so people can choose from it. The chosen format could get highlighted as replacing it with a long text would crash the Button bar completely.

By Hover or longer Tapping with the finger (on tablet/phone), the actual chosen value could be shown in the title tag.

In the de and fr (image shown below) locale at https://video.etherpad.com/, the alignment buttons are incorrectly showing in en.

Are corrections required at https://github.com/JohnMcLear/ep_align/blob/master/templates/editbarButtons.ejs#L4-L5 in the title property?

Thank you

with etherpad 1.8.6 (2c8769a) the buttons aren't showing up at all.

get the following console errors:
Failed to load 'ep_align/static/js/index' for 'ep_align/main/client_hooks/aceEditEvent': Not a function
Failed to load 'ep_align/static/js/index' for 'ep_align/main/client_hooks/postToolbarInit': Not a function
Failed to load 'ep_align/static/js/index' for 'ep_align/main/client_hooks/aceDomLineProcessLineAttributes': Not a function

When exporting a complete formatted file the given values do not get exported to .doc, .md, .odt, .pdf, etc.
Check issue ether/etherpad-lite#5211 as it is not clear if it is a problem with the core import/export functionality or a problem with the plugins that provide that information. The document inside etherpad gets actually properly formatted by those plugins!

That is the page that got exported! You can upload the NEW.ETHERPAD.txt file - remove (txt) before uploading.

Other export formats look as follow - on the same page:
Github doesn't like all formats so .txt got added and needs to get removed first.

• DOC - New.doc.txt
• ETHERPAD - New.etherpad.txt
• HTML - New.html.txt
• MD - New.md
• ODT - New.odt
• PDF - New.pdf
• TXT - New.txt

Hello. I install Etherpad and ep-align in Yunohost . The buttons are empty but they are fonctionnel.

All Alignment values do not get displayed in the File Menu

Maybe this is obvious, but took me a little while to figure out. Perhaps the readme could be updated to explain that the etherpad-lite settings file needs the toolbar section uncommented and the following added to it:-

  ["alignLeft", "alignCenter", "alignJustify", "alignRight"],

(It did for me anyway)