ethanroday / scorerenderer Goto Github PK

Since the renderer now makes multiple passes, the accept() method should be renamed to something more sensible, like positionElements().

Several methods in ScoreLeaf and ScoreComposite are identical and should be factored out into a new ScoreComponent class, from which ScoreLeaf and ScoreComposite should inherit.
Specifically, the methods are:

• isStretchableX
• isShrinkableX
• accept
• generateSims
• drawCrosshair
• drawBoundingBox

All direct access to component.children should instead use the pattern methods addChild, removeChild, and getChild.

In order to correctly discern between the score's tree and the actual formatted object graph, we must make the following distinction:

• add() will now be the method for the developer-facing score model.

• addChild() will now be the method for the internal composite structure.

• Each class will keep track of a nextLevelDown attribute, so that the implementation of the add() method can be encapsulated in ScoreComponent as:

  add(child) {
      this.nextLevelDown.addChild(child);
  }
  

  Thus, the constructor of ScoreComponent should contain this.nextLevelDown = this as the default, and subclasses can modify if needed. For example, Part should have this.nextLevelDown = this.voiceGroup.

Update methods should be eliminated and replaced with Object.defineProperty() for the properties involved. For example,

Renderer.Chord.prototype.update = function(duration,numDots,articulation) {
    this.updateDuration(duration);
    this.updateNumDots(numDots);
    this.updateArticulation(articulation);
};

and the methods that it calls should in turn be refactored into three Object.defineProperty() calls: one for duration, one for numDots, and one for articulation.