Bug Description

When working with pactum for E2E testing and NestJS for the HTTP server framework, I ran into a bug when trying to make a request to http://[::1]:3000 about [::1] not being as found address. After digging in more I found that pactum uses phin and phin uses centra.

Current Behavior

You can run the following in a Node REPL. I'll make a full minimum reproduction repository if you'd like me to as well 😄

centra('http://[::1]:3000').send().then(console.log)

And receive the error

Uncaught Error: getaddrinfo ENOTFOUND [::1]
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26)
    at GetAddrInfoReqWrap.callbackTrampoline (node:internal/async_hooks:130:17) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: '[::1]'
}

Expected Behavior

I should be able to make an HTTP request using an IPv6 with brackets separating the host and the port

Proposed Solution

The reason for this error is due to the URL.hostname property. The hostname itself should resolve to ::1 instead of [::1] as described in this issue on the Node repo. For node 15+ we can use urlToHttpOptions() from the url package instead of using Object.assign() on line 109 onf CentraRequest.js. However, if support for Node 12 and 14 is still required, we can do two replaces for the [ and ] characters, as they're not valid http host characters anyways.

I'm more than happy to implement this, just need to know which approach you'd prefer

Other information

Node: 16.13.0

It would be helpful for requests to support a Stream as the request body. I believe this is actually fairly simple, in that the query function needs to distinguish a StreamReader parameter and then send needs to use Stream.pipeline to connect the reader and request writer. Node.js' HTTP does the chunking automatically. At least that's my theory of how it would work ;-)
NB: I was trying to use phin, so ensuring phin can use this would be good too, I believe it just passes the data field through, so that should be automatic.

currently im trying to buffer an image,
const req = require('centra') const code = encodeURIComponent(err) const img = await req(https://zakazar.herokuapp.com/code-img/` + code)
`
how to i turn this into a buffer?
the api returns an image of the code i input
as an example

We tried using centra for our HTTP requests in a React application but then a TypeError occurs and we cannot make any request.

I already saw there was a similar issue but with browserify. Is there maybe any connection with fixing the error?

What we use:
node - v14.15.3
centra - 2.4.2
react - 17.0.1

When using Browserify or Webpack with this, this error occurs:

This can be worked around by editing the code to use url.parse instead, but I don't think this is a proper solution.

Hello. Is there a reason, why content-length header is set only for form data? Thanks.

null is appended to the URL when using Browserify or Webpack, causing problems.

I'll make a PR to fix this.

Ethan made this repo, which means it is either a clone of something that already exists or he spent 15 minutes on it. I suspect it is the latter.

See ethanent/phin#59

Centra uses the http package (in CentraRequest.js) but this package seems to have been removed because it contained malicious code : see this page.

What am I supposed to do to use Centra ?

Since there are already great libraries out there solving this very problem, it would be useful to know yr motivation to create this project.
Good luck!

Requested originally in Phin: ethanent/phin#56

Describe

querystring in Node.js (latest) is marked as legacy support, while it's still being maintained, it's recommended to avoid using querystring where possible. In fact VSCode marked querystring as deprecated to use.
https://nodejs.org/api/querystring.html