Code Monkey home page Code Monkey logo

bundler-spec-tests's People

Contributors

alex-miao avatar drortirosh avatar forshtat avatar hazim-j avatar plusminushalf avatar shahafn avatar tongshi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bundler-spec-tests's Issues

Test failed due to letter case not matching in userOp

When testing, I have some tests in test_bundler failed due to letter case not matching in userOp.initCode.
It would be better if tests can support case insensitive comparison of userOp, as letter case in hex string is not important.
Have opened a pr for this, thank you.
#54

Discrepancies in PVG across bundlers causes UserOps to be rejected in the Mempool

Although most bundlers adhere to the reference implementation for determining the Pre-Verification Gas (PVG) of a bundle (https://github.com/eth-infinitism/bundler/blob/main/packages/sdk/src/calcPreVerificationGas.ts), discrepancies still arise across different bundler implementations.

This variation in PVG leads to instances where UserOps deemed valid by one bundle are rejected by another.

For instance, a UserOp processed by Skandha yields a PVG of 44668, while 44848 estimates the same operation at 44848, resulting in the rejection of the UserOp from the mempool.

To mitigate this issue, it may be necessary to standardize PVG values across bundler implementations or at least reach consensus on minimum PVG thresholds for a bundle of X to prevent fragmentation of the mempool.

We need a test for this added to the p2p spec test suite as well.

IndexError: list index out of range

While testing on Polygon Mumbai with I am getting

>       account = w3.eth.accounts[0]
E       IndexError: list index out of range

command I am running

pdm run pytest -rA -W ignore::DeprecationWarning --url http://localhost:3000/rpc --entry-point 0x1306b01bC3e4AD202612D3843387e94737673F53 --ethereum-node https://rpc.ankr.com/polygon_mumbai

Issue running tests on latest Geth 1.13.0

Compliance tests do not work with latest Geth 1.13.0 release

FAILED tests/bundle/test_codehash.py::test_codehash_changed[] - AssertionError: could not create account with a different codehash
assert '0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470' != '0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470'

Failed CI run on Skandha bundler: https://github.com/etherspot/skandha/actions/runs/6160886035/job/16719407282
Failed CI run on Stackup bundler: https://github.com/stackup-wallet/stackup-bundler/actions/runs/6219516263/job/16877738642

Note: Works fine with previous versions such as 1.12.2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.