esri / torii-provider-arcgis Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 2.81 MB

Torii Provider for ArcGIS.com wrapped as an Ember-CLI Addon

Home Page: https://esri.github.io/torii-provider-arcgis/

License: Apache License 2.0

JavaScript 88.04% HTML 5.10% CSS 0.10% Handlebars 6.76%

torii-provider-arcgis's People

Contributors

Stargazers

Watchers

Forkers

isabella232

torii-provider-arcgis's Issues

demo app will be busted when we move to Esri org

solution

add esri.github.io/ as another valid redirect_uri for the registered sample app

client_id: zDbzLJW6W4tcxHkj

not sure who owns the item though...

fetch and 302 redirects and POST

In debugging an issue with Portal, the backing system was setup so that http requests to the api would be 302'd to https requests.

It seems like fetch would follow the 302, but was not smart enough to send the same body if the first request was a POST. Rather, it would send a GET, w/o the f=json&token=34b2js... and that would return the html, which would 💣 the app.

I propose we change that call to force a GET --> return arcgisRest.request(userUrl, { authentication: authMgr, httpMethod: 'GET' });

Still checking if this is a Portal/Enterprise thing, or something unique to this one env. If the latter, we may not need this, but should still consider looking into why the 302 is respected, but the form is not re-sent.

Redirect URL is incorrect if baseURL is other than root

If config.baseURL is set to a value other /, the redirect URL ignores it and just redirects to the root.
This can be resolved by modifying the value of _currentBaseUrl at line 37 of arcgis-oauth-bearer.js to include config.baseURL.
Importing config is needed.
I've tested this change on localhost and a github page deploy and it worked.

Use ArcGIS-Rest-Js

Ember Issues:

after importing both arcgis-rest-auth and arcgis-rest-request we only see arcgis-rest-auth in vendor.js
after importing either of them, the build time jumps to ~5 minutes... I suspect it's because we are minifiying already minified code.

ArcGIS Rest Issues

can we also ship un-minified umd output?
UserSession.beginOAuth2 does not support the following:
- passing additional flags - showSocialLogins, display
- specifying pop-up window size
Ergonomics of UserSession.completeOAuth2 - more a general thing.

Notes

UserSession.completeOAuth2

This requires use to use arcgis-rest-js within theredirect.html file, as well as getting the clientId into that context. Given that we can/have been doing this with ~4 lines of javascript in the <head> of redirect.html, this seems like overkill.

If UserSession.beginOAuth2 could register the callback with a consistent name - i.e. window['__ESRI_REST_AUTH_HANDLER'] instead of window['__ESRI_REST_AUTH_HANDLER_${clientid}'] this would greatly simplify things.

Regardless, we can't use this in torii-provider-arcgis because we need to use the mechanism provided by torii.