The hubot-baseball from erunion

hubot-baseball's Introduction

hubot-baseball

A Hubot plugin for pulling in today's MLB games (and scores).

Usage

hubot baseball - Pulls today's games
hubot baseball <team abbreviation> - Pulls today's game for a given team (ex. SF, NYY).

Installation

npm install hubot-baseball --save
Add "hubot-baseball" to your external-scripts.json file.
Reboot Hubot.

Contributors

hubot-baseball's People

Contributors

Stargazers

Watchers

hubot-baseball's Issues

fails if there's only one game today

It's "opening night", only one game today, (Cards/Cubs):

rybot baseball

(from logs:)
[Sun Apr 05 2015 17:23:57 GMT+0000 (UTC)] ERROR TypeError: undefined is not a function
at /home/ryan/node_modules/hubot-baseball/src/baseball.coffee:29:19, :23:15

Seems sorting one item fails there?

data input file is: http://gd2.mlb.com/components/game/mlb/year_2015/month_04/day_05/master_scoreboard.json

in that json, data.games.game is a singular object, NOT an array.

in json from a couple days prior:
http://gd2.mlb.com/components/game/mlb/year_2015/month_04/day_03/master_scoreboard.json

... data.games.game is an array, with a length.

Unclear whether they've change the json format for this season, or if it's an edge-case for days with one game. I guess we'll know tomorrow.

note, this phenomenon occurred last time there was one game on a day, in the playoffs. compare October:
several 1st round playoff games:
http://gd2.mlb.com/components/game/mlb/year_2014/month_10/day_05/master_scoreboard.json

game 7 of world series, single game:
http://gd2.mlb.com/components/game/mlb/year_2014/month_10/day_29/master_scoreboard.json

(disclosure: I used to work at MLBAM, and know more about the backend stuff that's generating these files than perhaps I should. :) )

Better team detection

Right now team detection requires team abbreviations, which aren't always that obvious (SFG and SF are both allowable for the Giants), so it'd be cool to add in a hardcoded list of team names so you could do:

hubot baseball giants