erob123 / acronym-web-app Goto Github PK

Steps to recreate:

This query:
acronyms?bullets=SS

Expected:

Normal API response

Actual:

Results in the following response:

{
   "timestamp":"2019-04-28T06:24:43.373+0000",
   "status":500,
   "error":"Internal Server Error",
   "message":"Query { 
      \"$java\" : Query: { \"name\" : \"SS\" }, 
      Fields: { }, 
      Sort: { } 
   } returned non unique result.","path":"/acronyms"
}

The Issue:

Looking at the mongo inject script, these two records exist on separate lines:

{"name": "SS","definition": ["Submarine"]},
{"name": "SS","definition": ["Sea State (Number)"]},

The Fix:

I would assume these should be combined:

{"name": "SS","definition": ["Sea State (Number)", "Submarine"]},

I didn't look to see if any of the other records were repeated.

If the app can't communicate with mongo, the request hangs in the browser.

It should only return one definition, even if the airman writes AA twice, for example.

Description:

In the DB, the description field is an array of descriptions. It would make that field slightly easier to consume on the front end if it could be sent as an array, instead of as a single string, as it is currently sent.

Current Response Format:

{"acronyms": [
   {
      "name":"AA",
      "definition":"Assessment Agent,Avenue Of Approach"
   },
   {
      // more acronyms
   }
]}

Requested Response Format:

{"acronyms": [
   {
      "name":"AA",
      "definition": [ "Assessment Agent", "Avenue Of Approach"]
   },
   {
      // more acronyms
   }
]}

Example

{
   name: "GB",
   description: "Group Buffer,Sarin, A Nerve Agent"
}

Commas are not used in exactly the same way for every record.