erl67 / weather-time-machine Goto Github PK

When I call the history servlet it just returns the last entry saved in the database for the user over and over again.

[
  {"UID":-1,"Title":"Pittsburgh, PA 15213, USA","Latitude":"40.4379259","Id":130,"Longitude":"-79.9556424","Date":"Sun Apr 16 00:00:00 EDT 2000","Name":"TestAccount"},
  {"UID":-1,"Title":"Pittsburgh, PA 15213, USA","Latitude":"40.4379259","Id":130,"Longitude":"-79.9556424","Date":"Sun Apr 16 00:00:00 EDT 2000","Name":"TestAccount"},
  {"UID":-1,"Title":"Pittsburgh, PA 15213, USA","Latitude":"40.4379259","Id":130,"Longitude":"-79.9556424","Date":"Sun Apr 16 00:00:00 EDT 2000","Name":"TestAccount"}
]

It returned more than 3 copies though. I think it is returning the right number of things, but they are all identical...

Obviously it should be returning each of the elements the elements in the database for the user instead.

Since the raw data is only relevant to the graph/chart, we should move it there or just get rid of it if it's not a feature.

I think I figured out a way to do this. Working on it today.

Right now for me the history api shows events from like 1100. Since the weather api cannot go that far back I suggest we limit the history to a certain decade.

Maybe there is feedback for this already but I just want to make sure the user knows they can't enter just any year.

Right now, to input using either field I use the Enter key but I think we should have working buttons too since our app is mobile friendly (and props for being mobile friendly, I'm betting the other teams are not)

We need to connect the graph to the Dark Sky API data so that it shows real data.

Steps

• Get needed data from API return (high and low temps)
• Put that data into an array that the graph can understand
• Make arrays for the axis labels based off of the years queried

I tried to fix it in the facade by checking the history object against the database via:
try {
if (em.find(WxHist.class, history) == null) {
em.persist(history);
return true;
}
}
But that prevented anything including new searches to be added, it always returned false with this:
$rootScope.displayError('Unable to add query to your history');

But that didn't work and keeps returning an error. Not sure why the objects are the same.
There should be away to change the JS where clicking on a previous search doesn't call /HistoryServlet

Right now the page just reloads if something is unsuccessful, it would be better if they could display an error message - either generic or specific to what actually went wrong.

Steps

• Submit form data via AJAX instead of native browser form
• Add error message banner to login/register page
• Have servlet response with error message

This isn't necessarily an issue but just some stuff to think about.

1. Do we want to show the exact temperatures for each point on the graph? You can hover over the dots to get the temperature already. It looks a bit crowded, especially when two of the lines are close together.
2. If we don't want to show all the temperatures, can we just show the high/low temps ones or is it all or nothing? We could try making the text transparent for the others...
3. The graph is almost unreadable on mobile. Do we want to worry about that, or not?
   

This might not be an option but I thought it would be helpful if the user can enter a title to include with their search to give it meaning. Like if I look up April 15, 1947 and Brooklyn, NY, USA, I would like to give it the title something like "Jackie Robinson Debuts for the Dodgers."

Clicking to log the user out doesn't actually delete the cookie needed to successfully log them out.

I think this is possible, looks like canvas chart has a function I can learn from.

And there is this for Canvas

So I can try this tonight. It will only be cosmetic and shouldn't break anything. I'll contain any changes I make to simple commits so that if anything happens, we can revoke them.

The time label next to the chart is cut off so you can only see half of it.

Show the user's previous queries that were stored in the database.

Steps

• Add box into page that shows the query history
• Hide box if no user is logged in
• Do AJAX call to get query history
• Maybe add a link to view results of each query again

It might just be me but when I click on the location button (with the pin drop icon) I expected it to do the weather search, but it doesn't seem to.

I'm going to see if I can pull an image from the geo search, make it faded and drop it in as a background to the chart. This is purely eye candy and I'll see if it improves the outcome.

This is a reminder for me to fix this mess

After making a failed search followed by a good one the red box with the error didn't go away. I did a few more good searches and the box never left.

Also after I did a search and logged out the page didn't change. It should probably reload to a clean page for security reasons.

Right now we are not checking to make sure that the date and location combinations we are querying are actually returning weather data.

Ideally we would detect that no data is available and try a different date, but we could also just show an error message

On database side, the username and password are both limited to 20 characters, so if you try to register with more it will fail, however the failure will only return null and a good registration returns the User Object, so I'm not sure how to pass those Exceptions. It would probably involve reworking the whole method.

Is there a way you restrict the length of those fields to 20 on the JS side?

Occasional CORS issues when fetching historical events. To fix this we would need to make a servlet that gets the historical events like the WeatherServlet.

Not super high priority because it usually works and only requires a page refresh to fix when it doesn't.

Steps

• Create an EventServlet that returns the historical events. Could essentially copy the WeatherServlet
• Switch call to get historical events in JS

This is something I forgot to do. I have the array already I just need to add it in.

When switching between the Events and Graph panels, the historical data box gets hidden after switching back to its panel.

Maybe it's just me but on the desktop the container for the input is really tall and takes most of the screen when I think it would be better for it to be narrow so that the user doesn't have to scroll down to see the history and graph. I started looking around to see how to adjust it but so far I'm not sure how.