erik / holepunch Goto Github PK

Due to the way the AWS Security Group API works, we're only able to revoke security group rules which match exactly all the keys we pass in.

In the case of existing rules that conflict with what we add, the only thing differing may be the description field, still resulting in the groups failing to be removed.

Given that the flag is --remove-existing, this behavior is unexpected.

See: #22

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RevokeSecurityGroupIngress.html

Opening this issue to track a visibility-raising comment once Boto3 introduces support for the just-announced commenting for security groups.

Sorry for bothering again, but I upgraded to 0.7.1 for the botocore fix and now it only adds my external v6 address and I cannot connect to my servers via v4.

I see two solutions here:

1. add both v4 and v6 to whitelist
2. add a flag to choose the IP version on the commandline

Hi, I think that would be really valuable to have option such as: '--remove-only'.
I've noticed that sometimes network sessions / tokens (depends of configuration) - can expired and then holepunch is not able to remove configuration, becuase is returing only error:

Skipping existing permission: {"ToPort": 443, "IpProtocol": "tcp", "IpRanges": ...
No changes to make.

So this means that my rule still exists - and I can't remove it. And running something like:

holepunch .... --remove-only

Could remove rule if exists.

The latest awscli uses botocore-1.8.21 and then holepunch is not working anymore.

Would be nice to add functionallity to work with AWS profiles - like most of AWS commands are working: --profile XXX

Links:

• http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html
• http://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html

Instead of waiting for Ctrl+c I would love an option to run a subcommand and to close the ingress when this subcommand exits.

Use case: Run SSH to a host and wrap it with holepunch to open access

Proposed syntax: holepunch -c "ssh myserver" <mySecGrpId> 22

Rather than identifying the SG by name (I inherited a mess), it would be easier to quote the group ID.

Thanks.