eranif / notebook Goto Github PK

Hi Eran,
I want to migrate my app to the notebook but I have questions

1. Is this the same as CL notebook?
2. Is API compatible with Aui notebook?
   Thanks

The year is 2019, am using vs 2019, wxwidgets 3.12, c++11 and unfortunately I cant get to compile my project with your project. I am getting the following errors on my end:

Error	LNK2019	unresolved external symbol "public: void __thiscall wxXmlResource::AddHandler(class wxXmlResourceHandler *)" (?AddHandler@wxXmlResource@@QAEXPAVwxXmlResourceHandler@@@Z) referenced in function "public: __thiscall Notebook::Notebook(class wxWindow *,int,class wxPoint const &,class wxSize const &,long,class wxString const &)" (??0Notebook@@QAE@PAVwxWindow@@HABVwxPoint@@ABVwxSize@@JABVwxString@@@Z)	MyApp	D:\cpp\MyApp\MyApp\Notebook.obj	1	
Error	LNK2019	unresolved external symbol "public: class wxBitmap __thiscall wxXmlResource::LoadBitmap(class wxString const &)" (?LoadBitmap@wxXmlResource@@QAE?AVwxBitmap@@ABVwxString@@@Z) referenced in function "public: virtual void __thiscall clTabInfo::Colours::InitDarkColours(void)" (?InitDarkColours@Colours@clTabInfo@@UAEXXZ)	MyApp	D:\cpp\MyApp\MyApp\Notebook.obj	1	
Error	LNK2019	unresolved external symbol "public: static class wxXmlResource * __cdecl wxXmlResource::Get(void)" (?Get@wxXmlResource@@SAPAV1@XZ) referenced in function "public: virtual void __thiscall clTabInfo::Colours::InitDarkColours(void)" (?InitDarkColours@Colours@clTabInfo@@UAEXXZ)	MyApp	D:\cpp\MyApp\MyApp\Notebook.obj	1	
Error	LNK2001	unresolved external symbol "public: static class wxXmlResource * __cdecl wxXmlResource::Get(void)" (?Get@wxXmlResource@@SAPAV1@XZ)	MyApp	D:\cpp\MyApp\MyApp\notebook_bitmaps.obj	1	
Error	LNK2019	unresolved external symbol "public: __thiscall wxBitmapXmlHandler::wxBitmapXmlHandler(void)" (??0wxBitmapXmlHandler@@QAE@XZ) referenced in function "public: __thiscall Notebook::Notebook(class wxWindow *,int,class wxPoint const &,class wxSize const &,long,class wxString const &)" (??0Notebook@@QAE@PAVwxWindow@@HABVwxPoint@@ABVwxSize@@JABVwxString@@@Z)	MyApp	D:\cpp\MyApp\MyApp\Notebook.obj	1	
Error	LNK2019	unresolved external symbol "public: bool __thiscall wxXmlResource::Load(class wxString const &)" (?Load@wxXmlResource@@QAE_NABVwxString@@@Z) referenced in function "void __cdecl Notebook_Init_Bitmaps(void)" (?Notebook_Init_Bitmaps@@YAXXZ)	MyApp	D:\cpp\MyApp\MyApp\notebook_bitmaps.obj	1	
Error	LNK1120	5 unresolved externals	MyApp	D:\cpp\MyApp\MyApp\vc_mswud\MyApp.exe	1	

I wanted to access m_tabCtrl so that I can calculate current tab index and found its private and so unavailable in my current class. Is there specific reason or its just a bug?

Hi,
I can see more updates have been done in CL for Notebook than in this.
Will it be allowed for me to port back changes in form of PR from CodeLite to this repo?
I ask because notebook in CodeLite have different license attached than this one.

Thanks

Sometimes I open files with long names and it makes it terrible. If its not very demanding can you add fixed tabs style? If it a lot of work, can you point me to the right direction to do that?

duplicate

Today I tried to Migrate from wxAuiNotebook and I failed. I Could not find equivalent for wxEVT_AUINOTEBOOK_TAB_RIGHT_UP. Is there any?

I find this troubling, especially in CodeLite, and since it s originating here, I thought I would open issue here.
Sometimes I want to do something (like right click -> close) the tab that isn't active, but I find I have to select it before I get context menu.
Is it possible to have both world (or in case I missed, any options). I want to implement in my app using this control and also would love to see it back in CodeLite!

Just to thank you for keeping this component alive
Thank you for your time!

duplicate

I have been trying to build this component on codelite but its seems like my problem is on compiler. The documentation on the site for the Ide is outdated. Kindly help me out

I have found that there is a memory leak from each clRenderer because they are created by "new" and stored by pointer in ms_Renderers, but are never deleted.

I have new code that fixes the issue when the Notebook goes out of scope, but I can't fork and PR because I get 403 forbidden accessing your repository.

Here are the changes I made.

1. clTabRenderer.h : public: static void DeleteRenderers(void) { for (auto& r : ms_Renderes) delete r.second; }
2. Notepad.cpp : Notebook::~Notebook() { clTabRenderer::DeleteRenderers(); }

That's it. It works.