Finishing Blow is adding spellbonuses twice about server HOT 4 CLOSED

My pull request should resolve this. Good eye, mine definitely aren't. 👍

from server.

The first part is the finishing blow health ratio limit.

auto fb_hp_limit = std::max(
	{
		aabonuses.FinishingBlowLvl[SBIndex::FINISHING_BLOW_LEVEL_HP_RATIO],
		spellbonuses.FinishingBlowLvl[SBIndex::FINISHING_BLOW_LEVEL_HP_RATIO],
		itembonuses.FinishingBlowLvl[SBIndex::FINISHING_BLOW_LEVEL_HP_RATIO]
	}
);

The second part is the finishing blow maximum level limit.

uint32 FB_Level = 0;
FB_Level = aabonuses.FinishingBlowLvl[SBIndex::FINISHING_EFFECT_LEVEL_MAX];
if (FB_Level < spellbonuses.FinishingBlowLvl[SBIndex::FINISHING_EFFECT_LEVEL_MAX])
	FB_Level = spellbonuses.FinishingBlowLvl[SBIndex::FINISHING_EFFECT_LEVEL_MAX];
else if (FB_Level < itembonuses.FinishingBlowLvl[SBIndex::FINISHING_EFFECT_LEVEL_MAX])
	FB_Level = itembonuses.FinishingBlowLvl[SBIndex::FINISHING_EFFECT_LEVEL_MAX];

from server.

So in the picture i was just showing that for level hp ratio you have aa spell and item, for damage you have aa spell and item, for max level you have aa spell and item, but for proc chance you have aa spell and spell. instead of aa spell and item or aa and spell once.
lines 5215 and 5216
int ProcChance = aabonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE] + spellbonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE] + spellbonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE];
wouldnt they be
int ProcChance = aabonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE] + spellbonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE] + itembonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE];
or
int ProcChance = aabonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE] + spellbonuses.FinishingBlow[SBIndex::FINISHING_EFFECT_PROC_CHANCE];
?

from server.

My apologies. I didn't even see the boxes to the side there. Should definitely be itembonuses there instead of spellbonuses twice.

from server.