If a task is completed more than once and rule KeepOneRecordPerCompletedTask is true - the task is completely erased from db about server HOT 6 CLOSED

It's a bug, changing

size_t erased = before - m_completed_tasks.size();
should fix it

from server.

It's a bug, changing

Server/zone/task_client_state.cpp

Line 422 in b1d873d

size_t erased = m_completed_tasks.size() - before;

to
size_t erased = before - m_completed_tasks.size(); should fix it

How? size_t is always unsigned. So it deleted no matter the order?

The delete seems correct, but I don't see where the new one is added to the db?

from server.

before should be greater than m_completed_tasks.size() after the erase, so currently erased will underflow and cause m_last_completed_task_loaded to increment instead of decrement after sign conversions. This prevents the db replace in SaveClientState because it's now bigger than m_completed_tasks.size. I assume the task code is just using that variable as a dirty flag for a db update.

edit:

How? size_t is always unsigned. So it deleted no matter the order?

Yes this would delete no matter the order if something was erased, just the db replace doesn't occur to reinsert it with updated time

from server.

You ok with PRing this since you clearly have a better grasp?

from server.

Feel free, it needs confirmation anyway

from server.

I've disabled the rule locally. I don't feel comfortable taking this on.

from server.